You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2011/07/05 16:01:47 UTC
Re: Review Request: WW-3659 - strange behaviour with tag
in the body
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1003/
-----------------------------------------------------------
(Updated 2011-07-05 14:01:47.633497)
Review request for Struts2.
Summary (updated)
-------
This change will solve https://issues.apache.org/jira/browse/WW-3659 but can be backward incompatibile
Diffs
-----
./core/src/main/resources/template/simple/a-close.ftl 1141925
./core/src/main/resources/template/simple/a.ftl 1141925
Diff: https://reviews.apache.org/r/1003/diff
Testing
-------
Thanks,
Lukasz
Re: Review Request: WW-3659 - strange behaviour with
tag in the body
Posted by Lukasz Lenart <lu...@apache.org>.
2011/7/5 Wesley Wannemacher <we...@apache.org>
>
> Lukasz, I'm not sure what makes this change backwards incompatible... I would say "ship it" but I'm more curious about why moving this to the closing template would make a difference. One thing that I noticed about the original issue is that the poster is setting the variable in "page" scope, then attempting to access the variable from another page that is included. I haven't spent time looking at the example war that the poster attached, but I will say this - I don't have a problem with this change, but I might have a problem with the motivation for making the change and I would also want to look closer at our UIBean and ClosingUIBean if the opening template is rendered differently than the closing template.
>
>
I've compared how <s:a/> tag is developed to <s:div/> tag, in theory they
should look the same, but differ in implementation. I don't know why Anchor
defines useBody() to true, Div doesn't and it works the same. I've removed
${parameters.body} and useBody() from <s:a/> and it works as expected
(<s:include/> is evaluated).
I'm playing with different configurations to see how Anchor tag is behaving.
It looks like a problem with Anchor class and not with UIBean. Maybe it's
because of different ways to pass parameters....
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
Re: Review Request: WW-3659 - strange behaviour with
tag in the body
Posted by Maurizio Cucchiara <ma...@gmail.com>.
Done
On 5 July 2011 17:09, Wes Wannemacher <we...@wantii.com> wrote:
> On Tue, Jul 5, 2011 at 11:05 AM, Maurizio Cucchiara
> <ma...@gmail.com> wrote:
> [snip]
> > Furthermore I would downgrade the issue's priority to minor (IMHO is a
> rare
> > case).
> > WDYT?
>
>
> Agreed!
>
> -Wes
>
> --
> Wes Wannemacher
>
> Head Engineer, WanTii, Inc.
> Need Training? Struts, Spring, Maven, Tomcat...
> Ask me for a quote!
>
--
Maurizio Cucchiara
Re: Review Request: WW-3659 - strange behaviour with
tag in the body
Posted by Wes Wannemacher <we...@wantii.com>.
On Tue, Jul 5, 2011 at 11:05 AM, Maurizio Cucchiara
<ma...@gmail.com> wrote:
[snip]
> Furthermore I would downgrade the issue's priority to minor (IMHO is a rare
> case).
> WDYT?
Agreed!
-Wes
--
Wes Wannemacher
Head Engineer, WanTii, Inc.
Need Training? Struts, Spring, Maven, Tomcat...
Ask me for a quote!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Review Request: WW-3659 - strange behaviour with
tag in the body
Posted by Maurizio Cucchiara <ma...@gmail.com>.
Hi guys,
I was trying to investigate what really happens, but in the last days I have
had no much free-time.
Rather I would say: let's see what really causes the problem and let's try
to preserve the backward compatibility before considering to apply Lukasz's
patch.
Furthermore I would downgrade the issue's priority to minor (IMHO is a rare
case).
WDYT?
On 5 July 2011 16:48, Wesley Wannemacher <we...@apache.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1003/#review960
> -----------------------------------------------------------
>
>
> Lukasz, I'm not sure what makes this change backwards incompatible... I
> would say "ship it" but I'm more curious about why moving this to the
> closing template would make a difference. One thing that I noticed about the
> original issue is that the poster is setting the variable in "page" scope,
> then attempting to access the variable from another page that is included. I
> haven't spent time looking at the example war that the poster attached, but
> I will say this - I don't have a problem with this change, but I might have
> a problem with the motivation for making the change and I would also want to
> look closer at our UIBean and ClosingUIBean if the opening template is
> rendered differently than the closing template.
>
> - Wesley
>
>
> On 2011-07-05 14:01:47, Lukasz Lenart wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/1003/
> > -----------------------------------------------------------
> >
> > (Updated 2011-07-05 14:01:47)
> >
> >
> > Review request for Struts2.
> >
> >
> > Summary
> > -------
> >
> > This change will solve https://issues.apache.org/jira/browse/WW-3659 but
> can be backward incompatibile
> >
> >
> > Diffs
> > -----
> >
> > ./core/src/main/resources/template/simple/a-close.ftl 1141925
> > ./core/src/main/resources/template/simple/a.ftl 1141925
> >
> > Diff: https://reviews.apache.org/r/1003/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Lukasz
> >
> >
>
>
--
Maurizio Cucchiara
Re: Review Request: WW-3659 - strange behaviour with tag
in the body
Posted by Wesley Wannemacher <we...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1003/#review960
-----------------------------------------------------------
Lukasz, I'm not sure what makes this change backwards incompatible... I would say "ship it" but I'm more curious about why moving this to the closing template would make a difference. One thing that I noticed about the original issue is that the poster is setting the variable in "page" scope, then attempting to access the variable from another page that is included. I haven't spent time looking at the example war that the poster attached, but I will say this - I don't have a problem with this change, but I might have a problem with the motivation for making the change and I would also want to look closer at our UIBean and ClosingUIBean if the opening template is rendered differently than the closing template.
- Wesley
On 2011-07-05 14:01:47, Lukasz Lenart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1003/
> -----------------------------------------------------------
>
> (Updated 2011-07-05 14:01:47)
>
>
> Review request for Struts2.
>
>
> Summary
> -------
>
> This change will solve https://issues.apache.org/jira/browse/WW-3659 but can be backward incompatibile
>
>
> Diffs
> -----
>
> ./core/src/main/resources/template/simple/a-close.ftl 1141925
> ./core/src/main/resources/template/simple/a.ftl 1141925
>
> Diff: https://reviews.apache.org/r/1003/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lukasz
>
>