[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #6536: tvmc: linting error on onnx command line driver frontend

[GitBox <gi...@apache.org>]

manupa-arm commented on a change in pull request #6536:
URL: https://github.com/apache/incubator-tvm/pull/6536#discussion_r493581644



##########
File path: python/tvm/driver/tvmc/frontends.py
##########
@@ -154,7 +154,8 @@ def load(self, path):
         # pylint: disable=C0415
         import onnx
 
-        model = onnx.load(path)
+        # pylint: disable=E1101

Review comment:
       Generally, being explicit and specific in lint exceptions are better, because this specific lint error (E1101) comes when accessing external imports which are not installed ci_lint.  If we disable it globally, we will miss the places where we want to capture it when we are accessing objects/modules defined in the code base.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org