[GitHub] [beam] mxm commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

[GitBox <gi...@apache.org>]

mxm commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators
URL: https://github.com/apache/beam/pull/11126#discussion_r395145834
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
 ##########
 @@ -265,18 +265,6 @@
      * data has been explicitly requested. See {@link Window} for more information.
      */
     public abstract PaneInfo pane();
-
-    /**
-     * Gives the runner a (best-effort) lower bound about the timestamps of future output associated
-     * with the current element.
-     *
-     * <p>If the {@link DoFn} has multiple outputs, the watermark applies to all of them.
-     *
-     * <p>Only splittable {@link DoFn DoFns} are allowed to call this method. It is safe to call
-     * this method from a different thread than the one running {@link ProcessElement}, but all
-     * calls must finish before {@link ProcessElement} returns.
-     */
-    public abstract void updateWatermark(Instant watermark);
 
 Review comment:
   This is a backwards-incompatible change. It probably does not affect many users but we should make sure to announce it, e.g. via the release notes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services