You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Anita Jebaraj <aj...@us.ibm.com> on 2017/03/09 17:08:12 UTC

Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/
-----------------------------------------------------------

Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.


Bugs: AMBARI-20363
    https://issues.apache.org/jira/browse/AMBARI-20363


Repository: ambari


Description
-------

In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters.


Diffs
-----

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c 


Diff: https://reviews.apache.org/r/57467/diff/1/


Testing
-------

Tested manually


Thanks,

Anita Jebaraj


Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/#review168484
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57467/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20363
>     https://issues.apache.org/jira/browse/AMBARI-20363
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c 
> 
> 
> Diff: https://reviews.apache.org/r/57467/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> File Attachments
> ----------------
> 
> Before Fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png
> After fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>


Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

Posted by Anita Jebaraj <aj...@us.ibm.com>.

> On March 9, 2017, 7:50 p.m., DIPAYAN BHOWMICK wrote:
> > Ship It!

Thank you for reviewing, can you please push the changes


- Anita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/#review168505
-----------------------------------------------------------


On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57467/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20363
>     https://issues.apache.org/jira/browse/AMBARI-20363
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c 
> 
> 
> Diff: https://reviews.apache.org/r/57467/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> File Attachments
> ----------------
> 
> Before Fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png
> After fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>


Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/#review168505
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57467/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20363
>     https://issues.apache.org/jira/browse/AMBARI-20363
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c 
> 
> 
> Diff: https://reviews.apache.org/r/57467/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> File Attachments
> ----------------
> 
> Before Fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png
> After fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>


Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/#review168489
-----------------------------------------------------------


Ship it!




Ship It!

- Sangeeta Ravindran


On March 9, 2017, 5:24 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57467/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 5:24 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20363
>     https://issues.apache.org/jira/browse/AMBARI-20363
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c 
> 
> 
> Diff: https://reviews.apache.org/r/57467/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> File Attachments
> ----------------
> 
> Before Fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png
> After fix
>   https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>


Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

Posted by Anita Jebaraj <aj...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/
-----------------------------------------------------------

(Updated March 9, 2017, 5:24 p.m.)


Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.


Bugs: AMBARI-20363
    https://issues.apache.org/jira/browse/AMBARI-20363


Repository: ambari


Description
-------

In the "Access Control and Status, clear the content of Users under the "Administer Queue". It' still shows the user icon in Effective Administraters.


Diffs
-----

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components/userGroupInput.js 513031c 


Diff: https://reviews.apache.org/r/57467/diff/1/


Testing
-------

Tested manually


File Attachments (updated)
----------------

Before Fix
  https://reviews.apache.org/media/uploaded/files/2017/03/09/6ca6a48d-cde2-4e1b-a209-aa898244c998__beforefix.png
After fix
  https://reviews.apache.org/media/uploaded/files/2017/03/09/062bb336-0706-442d-a638-f07f8f8363b3__afterFix.PNG


Thanks,

Anita Jebaraj