You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2012/07/18 20:32:49 UTC
svn commit: r1363037 - in
/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl:
AvalonLogger.java Log4JLogger.java
Author: sebb
Date: Wed Jul 18 18:32:49 2012
New Revision: 1363037
URL: http://svn.apache.org/viewvc?rev=1363037&view=rev
Log:
Make immutable private fields final
Modified:
commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/AvalonLogger.java
commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java
Modified: commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/AvalonLogger.java
URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/AvalonLogger.java?rev=1363037&r1=1363036&r2=1363037&view=diff
==============================================================================
--- commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/AvalonLogger.java (original)
+++ commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/AvalonLogger.java Wed Jul 18 18:32:49 2012
@@ -57,7 +57,7 @@ public class AvalonLogger implements Log
/** Ancesteral avalon logger */
private static Logger defaultLogger = null;
/** Avalon logger used to perform log */
- private transient Logger logger = null;
+ private final transient Logger logger;
/**
* Constructs an <code>AvalonLogger</code> that outputs to the given
Modified: commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java
URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java?rev=1363037&r1=1363036&r2=1363037&view=diff
==============================================================================
--- commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java (original)
+++ commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java Wed Jul 18 18:32:49 2012
@@ -58,7 +58,7 @@ public class Log4JLogger implements Log,
private transient Logger logger = null;
/** Logger name */
- private String name = null;
+ private final String name;
private static final Priority traceLevel;
@@ -100,6 +100,7 @@ public class Log4JLogger implements Log,
// ------------------------------------------------------------ Constructor
public Log4JLogger() {
+ name = null;
}