You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Vinod K V (JIRA)" <ji...@apache.org> on 2009/09/02 07:25:32 UTC

[jira] Created: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Move process tree, and memory calculator classes out of Common into Map/Reduce.
-------------------------------------------------------------------------------

                 Key: HADOOP-6230
                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
             Project: Hadoop Common
          Issue Type: Sub-task
            Reporter: Vinod K V




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750816#action_12750816 ] 

Hemanth Yamijala commented on HADOOP-6230:
------------------------------------------

I think the classes in mapreduce should be in the package o.a.h.mapreduce.util instead of o.a.h.util as the latter is currently being used to refer to classes that are common utilities across all sub-projects of Hadoop. Thoughts ?

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752036#action_12752036 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

`ant test' and `ant test-patch' passed for the common project's patch. Common patch can first be committed now.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-6230:
------------------------------

    Attachment: HADOOP-6230-20090903-mapred.txt
                HADOOP-6230-20090903-common.txt

Attaching updated patches moving the new files in mapred to o.a.h.mapreduce.util and deprecating the relevant files in o.a.h.util.

There are still two tests TestRunJar.java and TestReflectionUtils.java in o.a.h.mapreduce.util. The later doesn't clearly belong to mapreduce. Will create a new issue to move them to more appropriate locations.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-6230:
------------------------------

    Component/s: util

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: util
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751285#action_12751285 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

bq. TestReflectionUtils depends on JobConf, so it can't be moved in its entirety. Probably best to split it into core and mapreduce pieces.
Agreed Tom. Created HADOOP-6237 for the same.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750350#action_12750350 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

The common tests passes with the patch for common project.

I generated common jar and common test jar after applying the common patch and put them in mapreduce lib dir so as to run mapred and contrib tests. These tests also succeeded. 

These patches can be committed.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-6230:
------------------------------

    Release Note: Moved process tree, and memory calculator classes out of Common project into the Map/Reduce project.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-6230:
------------------------------

    Attachment: HADOOP-6230-20090902-mapred.txt
                HADOOP-6230-20090902-common.txt

Attaching two patches for this issue. The common patch removes the files and mapreduce patch adds them to the mapreduce project. DummyMemoryPlugin is already in mapreduce, so not doing anything with it.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752047#action_12752047 ] 

Hudson commented on HADOOP-6230:
--------------------------------

Integrated in Hadoop-Common-trunk #87 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/87/])
    . Moved process tree and memory calculator related classes from Common to Map/Reduce. Contributed by Vinod Kumar Vavilapalli.


> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750274#action_12750274 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

I've verified that the following are referenced only by mapred and so am going to move them into mapreduce project.

    * ProcessTree.java
    * ProcfsBasedProcessTree.java
    * MemoryCalculatorPlugin.java
    * DummyMemoryCalculatorPlugin.java
    * LinuxMemoryCalculatorPlugin.java
    * TestProcfsBasedProcessTree.java

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750392#action_12750392 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

ant `test-patch` results for both mapred and common return all +1s.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751058#action_12751058 ] 

Tom White commented on HADOOP-6230:
-----------------------------------

TestReflectionUtils depends on JobConf, so it can't be moved in its entirety. Probably best to split it into core and mapreduce pieces.  

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hemanth Yamijala resolved HADOOP-6230.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Incompatible change, Reviewed]

I just committed the mapreduce changes and the common project jars from Hudson build to the map/reduce subproject thus completing the move.

Thanks, Vinod !

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750353#action_12750353 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

I am outlining steps for committing this (Copied from MAPREDUCE-711)
    * First, commit the changes to common using the common patch.
    * Trigger a Hudson build of common and get the common jar and common test jar files.
    * Then, commit the following to mapreduce project.
         ** common jar and common test jar files picked up from Hudson to mapreduce/lib folder and
         ** changes to mapreduce sources using the mapreduce patch

No jars are needed to be committed to HDFS as of now.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V reassigned HADOOP-6230:
---------------------------------

    Assignee: Vinod K V

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752038#action_12752038 ] 

Hemanth Yamijala commented on HADOOP-6230:
------------------------------------------

I just committed to trunk. We should fire a hudson build to get jar files for testing the Map/Reduce changes.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751811#action_12751811 ] 

Hemanth Yamijala commented on HADOOP-6230:
------------------------------------------

This seems fine to me. +1.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752478#action_12752478 ] 

Hudson commented on HADOOP-6230:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #23 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/23/])
    

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752043#action_12752043 ] 

Hudson commented on HADOOP-6230:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #14 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/14/])
    . Moved process tree and memory calculator related classes from Common to Map/Reduce. Contributed by Vinod Kumar Vavilapalli.


> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6230) Move process tree, and memory calculator classes out of Common into Map/Reduce.

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752092#action_12752092 ] 

Vinod K V commented on HADOOP-6230:
-----------------------------------

I ran mapred, and contrib tests locally which have all passed.

Running `ant test-patch' got a bit trickier. I had to generate a special common jars with only the changes to Shell.java from the common patch and copy them over to mapred. I got all +1's except the following which are unavoidable:
{noformat}
        The class name org.apache.hadoop.util.LinuxMemoryCalculatorPlugin     
   Nm   shadows the simple name of the superclass                             
        org.apache.hadoop.mapreduce.util.LinuxMemoryCalculatorPlugin          
        [5]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)     
        In class org.apache.hadoop.util.LinuxMemoryCalculatorPlugin           
        In class org.apache.hadoop.mapreduce.util.LinuxMemoryCalculatorPlugin 
        At LinuxMemoryCalculatorPlugin.java:[line 28]                         
        The class name org.apache.hadoop.util.MemoryCalculatorPlugin shadows  
   Nm   the simple name of the superclass                                     
        org.apache.hadoop.mapreduce.util.MemoryCalculatorPlugin               
        [6]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)     
        In class org.apache.hadoop.util.MemoryCalculatorPlugin                
        In class org.apache.hadoop.mapreduce.util.MemoryCalculatorPlugin      
        At MemoryCalculatorPlugin.java:[lines 32-37]                          
   Nm   The class name org.apache.hadoop.util.ProcessTree shadows the simple  
        name of the superclass org.apache.hadoop.mapreduce.util.ProcessTree   
        [7]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)     
        In class org.apache.hadoop.util.ProcessTree                           
        In class org.apache.hadoop.mapreduce.util.ProcessTree                 
        At ProcessTree.java:[line 27]                                         
        The class name org.apache.hadoop.util.ProcfsBasedProcessTree shadows  
   Nm   the simple name of the superclass                                     
        org.apache.hadoop.mapreduce.util.ProcfsBasedProcessTree               
        [8]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)     
        In class org.apache.hadoop.util.ProcfsBasedProcessTree                
        In class org.apache.hadoop.mapreduce.util.ProcfsBasedProcessTree      
        At ProcfsBasedProcessTree.java:[lines 28-47]                          
{noformat}

The mapreduce patch is committable.

> Move process tree, and memory calculator classes out of Common into Map/Reduce.
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-6230
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6230
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>         Attachments: HADOOP-6230-20090902-common.txt, HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt, HADOOP-6230-20090903-mapred.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.