You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2021/10/06 20:38:00 UTC
[GitHub] [incubator-hop] hansva commented on a change in pull request #1117: HOP-3244
hansva commented on a change in pull request #1117:
URL: https://github.com/apache/incubator-hop/pull/1117#discussion_r723655889
##########
File path: plugins/transforms/tableoutput/src/test/java/org/apache/hop/pipeline/transforms/tableoutput/TableOutputTest.java
##########
@@ -198,6 +201,6 @@ public void testInit_unsupportedConnection() {
HopException ke = new HopException(unsupportedTableOutputMessage);
verify(tableOutputSpy, times(1))
- .logError("An error occurred intialising this transform: " + ke.getMessage());
+ .logError("An error occurred intializing this transform: " + ke.getMessage());
Review comment:
typo, initializing
##########
File path: plugins/transforms/tableoutput/src/main/java/org/apache/hop/pipeline/transforms/tableoutput/TableOutputMeta.java
##########
@@ -889,16 +899,15 @@ public void setSchemaName(String schemaName) {
@Override
public boolean supportsErrorHandling() {
- if (databaseMeta != null) {
- return databaseMeta.getIDatabase().supportsErrorHandling();
- } else {
- return true;
- }
+ return true;
+ }
+
+ public DatabaseMeta getDatabaseMeta() {
+ return null;
Review comment:
why is this getter still here?
##########
File path: plugins/transforms/tableoutput/src/main/java/org/apache/hop/pipeline/transforms/tableoutput/TableOutput.java
##########
@@ -562,7 +551,7 @@ public boolean init() {
return true;
} catch (HopException e) {
- logError("An error occurred intialising this transform: " + e.getMessage());
+ logError("An error occurred intializing this transform: " + e.getMessage());
Review comment:
typo, initializing
##########
File path: plugins/transforms/tableoutput/src/main/java/org/apache/hop/pipeline/transforms/tableoutput/TableOutputMeta.java
##########
@@ -429,6 +412,23 @@ public void check(
IRowMeta info,
IVariables variables,
IHopMetadataProvider metadataProvider) {
+ DatabaseMeta databaseMeta = null;
+
+ try {
+ databaseMeta =
Review comment:
make this a local variable, no need to declare empty variable first
##########
File path: plugins/transforms/tableoutput/src/main/java/org/apache/hop/pipeline/transforms/tableoutput/TableOutputMeta.java
##########
@@ -708,6 +708,19 @@ public void analyseImpact(
String[] output,
IRowMeta info,
IHopMetadataProvider metadataProvider) {
+
+ DatabaseMeta databaseMeta = null;
+
+ try {
+ databaseMeta =
Review comment:
make this a local variable, no need to declare empty variable first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org