You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/19 17:18:46 UTC
[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull
request #15412: [MXNET-978] Higher Order Gradient Support `sinh`, `cosh`.
kshitij12345 commented on a change in pull request #15412: [MXNET-978] Higher Order Gradient Support `sinh`, `cosh`.
URL: https://github.com/apache/incubator-mxnet/pull/15412#discussion_r305449670
##########
File path: src/operator/tensor/elemwise_unary_op_trig.cc
##########
@@ -92,7 +92,7 @@ The storage type of ``cos`` output is always dense
MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU(_backward_cos, unary_bwd<mshadow_op::cos_grad>)
.set_attr<nnvm::FGradient>("FGradient",
[](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) {
- // ograds[0]: head_grad_grads (dL/dx_grad)
+ // ograds[0]: head_grad_grads (dL/dy_grad)
Review comment:
Please have a look and let me know what you think.
https://github.com/apache/incubator-mxnet/pull/15331#discussion_r304541519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services