[GitHub] [samza] Sanil15 commented on a change in pull request #1267: SAMZA-2402: Tie Container placement service and Container placement handler and validate placement requests

[GitBox <gi...@apache.org>]

Sanil15 commented on a change in pull request #1267: SAMZA-2402: Tie Container placement service and Container placement handler and validate placement requests
URL: https://github.com/apache/samza/pull/1267#discussion_r376147358
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/container/placement/ContainerPlacementMetadataStore.java
 ##########
 @@ -259,6 +260,8 @@ static String toContainerPlacementMessageKey(UUID uuid, Class<?> messageType) {
         throw new SamzaException(e);
       }
     }
+    // Sort the actions in order of timestamp
+    newActions.sort(Comparator.comparingLong(ContainerPlacementRequestMessage::getTimestamp));
 
 Review comment:
   Note to reviewers: Metastore does not give any metadata fields related to a message so I have to manually sort to ensure messages are in increasing order of timestamp

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services