You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iceberg.apache.org by GitBox <gi...@apache.org> on 2018/12/06 19:26:45 UTC
[GitHub] mccheah commented on issue #28: Apply baseline checkstyle for
iceberg-api only
mccheah commented on issue #28: Apply baseline checkstyle for iceberg-api only
URL: https://github.com/apache/incubator-iceberg/pull/28#issuecomment-444998286
One thing that's tricky about applying this to `iceberg-api` is that the style changes can impact public-facing APIs. If we want, we can temporarily suppress the checkstyle warnings on those API methods and fields in order to avoid breaking users. On the other hand, we can hold the opinion that we're choosing to break API now for the express purpose of getting our APIs consistent with the standards across the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services