You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thomas Singer (JIRA)" <ji...@apache.org> on 2007/04/09 20:22:32 UTC

[jira] Created: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Make wicket.Component.renderClosingComponentTag() protected
-----------------------------------------------------------

                 Key: WICKET-454
                 URL: https://issues.apache.org/jira/browse/WICKET-454
             Project: Wicket
          Issue Type: Task
    Affects Versions: 1.2.5
            Reporter: Thomas Singer
             Fix For: 1.2.6


... so it can be invoked from a subclass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Closed: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner:
> it is "fixed" by using the IComponentBorder interface for that.

So maybe we should just change the issue title to something like:
IComponentBorder custom borders around component

So that it's more obvious for someone reading the ChangeLog.
-- 
     Jean-Baptiste Quenot
aka  John Banana   Qwerty
http://caraldi.com/jbq/

Re: [jira] Closed: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by Johan Compagner <jc...@gmail.com>.
it is "fixed" by using the IComponentBorder interface for that.



On 4/10/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Johan Compagner (JIRA):
> >
> >      [
> https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
> >
> > Johan Compagner closed WICKET-454.
> > ----------------------------------
> >
> >        Resolution: Fixed
>
> Do you mean Won't Fix?  Otherwise it will appear in the ChangeLog
> I guess.
> --
>      Jean-Baptiste Quenot
> aka  John Banana   Qwerty
> http://caraldi.com/jbq/
>

Re: [jira] Closed: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner (JIRA):
> 
>      [ https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Johan Compagner closed WICKET-454.
> ----------------------------------
> 
>        Resolution: Fixed

Do you mean Won't Fix?  Otherwise it will appear in the ChangeLog
I guess.
-- 
     Jean-Baptiste Quenot
aka  John Banana   Qwerty
http://caraldi.com/jbq/

[jira] Commented: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by "Thomas Singer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487759 ] 

Thomas Singer commented on WICKET-454:
--------------------------------------

I've searched JIRA or the dev-mailing list, but could not find something about IComponentBorder. Where can I download a copy of the current 1.3 implementation to see whether it suites my needs (trunk/ or branches/wicket-1.x/jdk-1.4/)?

> Make wicket.Component.renderClosingComponentTag() protected
> -----------------------------------------------------------
>
>                 Key: WICKET-454
>                 URL: https://issues.apache.org/jira/browse/WICKET-454
>             Project: Wicket
>          Issue Type: Task
>    Affects Versions: 1.2.5
>            Reporter: Thomas Singer
>             Fix For: 1.3
>
>
> ... so it can be invoked from a subclass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487591 ] 

Igor Vaynberg commented on WICKET-454:
--------------------------------------

what exactly is the usecase for overriding this?

> Make wicket.Component.renderClosingComponentTag() protected
> -----------------------------------------------------------
>
>                 Key: WICKET-454
>                 URL: https://issues.apache.org/jira/browse/WICKET-454
>             Project: Wicket
>          Issue Type: Task
>    Affects Versions: 1.2.5
>            Reporter: Thomas Singer
>             Fix For: 1.2.6
>
>
> ... so it can be invoked from a subclass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-454.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.2.6)
                   1.3

for that we have in 1.3 IComponentBorder where you can have custom borders around component.

> Make wicket.Component.renderClosingComponentTag() protected
> -----------------------------------------------------------
>
>                 Key: WICKET-454
>                 URL: https://issues.apache.org/jira/browse/WICKET-454
>             Project: Wicket
>          Issue Type: Task
>    Affects Versions: 1.2.5
>            Reporter: Thomas Singer
>             Fix For: 1.3
>
>
> ... so it can be invoked from a subclass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by "Thomas Singer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487688 ] 

Thomas Singer commented on WICKET-454:
--------------------------------------

An own Border implementation.

> Make wicket.Component.renderClosingComponentTag() protected
> -----------------------------------------------------------
>
>                 Key: WICKET-454
>                 URL: https://issues.apache.org/jira/browse/WICKET-454
>             Project: Wicket
>          Issue Type: Task
>    Affects Versions: 1.2.5
>            Reporter: Thomas Singer
>             Fix For: 1.2.6
>
>
> ... so it can be invoked from a subclass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-454) Make wicket.Component.renderClosingComponentTag() protected

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487787 ] 

Johan Compagner commented on WICKET-454:
----------------------------------------

ooopps that one almost died with 2.0..

i backported it to 1.3 but can't check it in yet

after that a build can be get from: http://wicketstuff.org/maven/repository/

or downloaded directly from svn

> Make wicket.Component.renderClosingComponentTag() protected
> -----------------------------------------------------------
>
>                 Key: WICKET-454
>                 URL: https://issues.apache.org/jira/browse/WICKET-454
>             Project: Wicket
>          Issue Type: Task
>    Affects Versions: 1.2.5
>            Reporter: Thomas Singer
>             Fix For: 1.3
>
>
> ... so it can be invoked from a subclass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.