You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/06/07 04:48:50 UTC
[kudu-CR] [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18594
Change subject: [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
......................................................................
[kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
This patch updates the expected message on connection negotiation
timeout in the ToolTest.ConnectionNegotiationTimeoutOption scenario,
making it more robust.
Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18594/1
--
To view, visit http://gerrit.cloudera.org:8080/18594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18594 )
Change subject: [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 06:13:25 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18594 )
Change subject: [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
......................................................................
Patch Set 1: Verified+1
unrelated test failure in ParameterizedAddMasterTest.TestAddMasterSysCatalogCopy/3
--
To view, visit http://gerrit.cloudera.org:8080/18594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 16:58:13 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18594 )
Change subject: [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 17:13:16 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18594 )
Change subject: [kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
......................................................................
[kudu-tool-test] more robust ConnectionNegotiationTimeoutOption
This patch updates the expected message on connection negotiation
timeout in the ToolTest.ConnectionNegotiationTimeoutOption scenario,
making it more robust.
Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Reviewed-on: http://gerrit.cloudera.org:8080/18594
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Alexey Serbin: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a34fc03f67c2ae3b5ff6b4f746dd87d79634c52
Gerrit-Change-Number: 18594
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>