[GitHub] [iceberg] nastra commented on a diff in pull request #5773: Core: Deprecate write.manifest-lists.enabled flag

[GitBox <gi...@apache.org>]

nastra commented on code in PR #5773:
URL: https://github.com/apache/iceberg/pull/5773#discussion_r989806000


##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -76,18 +76,8 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio
       generator.writeEndObject();
     }
 
-    String manifestList = snapshot.manifestListLocation();
-    if (manifestList != null) {
-      // write just the location. manifests should not be embedded in JSON along with a list
-      generator.writeStringField(MANIFEST_LIST, manifestList);
-    } else {
-      // embed the manifest list in the JSON, v1 only
-      generator.writeArrayFieldStart(MANIFESTS);
-      for (ManifestFile file : snapshot.allManifests(DUMMY_FILE_IO)) {
-        generator.writeString(file.path());
-      }
-      generator.writeEndArray();
-    }
+    // write just the location. manifests should not be embedded in JSON along with a list
+    generator.writeStringField(MANIFEST_LIST, snapshot.manifestListLocation());

Review Comment:
   ok good point, I added that piece back



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org