You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by Oliver Zeigermann <oz...@c1-fse.de> on 2003/11/26 13:43:38 UTC

Re: cvs commit: jakarta-slide/proposals/stores/org/apache/slide/s tore/impl/rdbms MySqlSchema.sql

Wendt, Alexander wrote:

>>Zeigermann, Oliver wrote:
>>
>>Sounds reasonable to me.
>>
>>Pier Fumagalli wrote:
>>
>>
>>>Why int(11) and not bigint (which is EXACTLY as a Java "long"?)...
>>>
>>>Also, the only difference in the adapter from the standard to the MySQL
>>>adapter is the fact that the lock EXPIRATION_DATE is a DATE in MySQL.
>>>IMO, this is wrong, as you loose any information about the time, right?
>>>If you change it to be a BIGINT, then you can also forget about the
>>>modifications in MySqlAdapter.java :-)
> 
> 
> As I have only done a little bit cleaning of the pure mysql-schema, I can
> not answer this question.
> 
> But if these modifications are the only reason for MySQLAdapter.java, Pier
> is right.
> 
> 
> regards,
> alex.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> 
> 
> .
> 

OK, seems I waited enough for comments. So, I will make int(11) bigint 
and have EXPIRATION_DATE as bigint as well, thus allowing to remove 
modifications in MySqlAdapter.

30 minutes to stop me now...

Oliver




---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-slide/proposals/stores/org/apache/slide/s tore/impl/rdbms MySqlSchema.sql

Posted by Pier Fumagalli <pi...@betaversion.org>.
On 26 Nov 2003, at 15:15, Oliver Zeigermann wrote:
> Stefano Mazzocchi wrote:
>> On 26 Nov 2003, at 14:23, Martin Holz wrote:
>>> Oliver Zeigermann <oz...@c1-fse.de> writes:
>>>
>>>
>>>> OK, seems I waited enough for comments. So, I will make int(11) 
>>>> bigint
>>>> and have EXPIRATION_DATE as bigint as well, thus allowing to remove
>>>> modifications in MySqlAdapter.
>>>>
>>>>
>>>> 30 minutes to stop me now...
>>>
>>>
>>> Nice thing about cvs, we can alway undo changes. No reason to wait
>>> an other 30 minutes.
>> Commit then review, Oliver, believe me, it works! it really does :-)
>
> Hehehehehehehehehehe :) I will check in my own stuff, but this is a 
> check in on behalf of Pier and Alex...
>
> Anyway, done now :)

+1 :-) Go dude! :-)

	Pier


---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-slide/proposals/stores/org/apache/slide/s tore/impl/rdbms MySqlSchema.sql

Posted by Oliver Zeigermann <oz...@c1-fse.de>.
Stefano Mazzocchi wrote:

> 
> On 26 Nov 2003, at 14:23, Martin Holz wrote:
> 
>> Oliver Zeigermann <oz...@c1-fse.de> writes:
>>
>>
>>> OK, seems I waited enough for comments. So, I will make int(11) bigint
>>> and have EXPIRATION_DATE as bigint as well, thus allowing to remove
>>> modifications in MySqlAdapter.
>>>
>>>
>>> 30 minutes to stop me now...
>>
>>
>> Nice thing about cvs, we can alway undo changes. No reason to wait
>> an other 30 minutes.
> 
> 
> Commit then review, Oliver, believe me, it works! it really does :-)

Hehehehehehehehehehe :) I will check in my own stuff, but this is a 
check in on behalf of Pier and Alex...

Anyway, done now :)

Oliver



---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-slide/proposals/stores/org/apache/slide/s tore/impl/rdbms MySqlSchema.sql

Posted by Stefano Mazzocchi <st...@apache.org>.
On 26 Nov 2003, at 14:23, Martin Holz wrote:

> Oliver Zeigermann <oz...@c1-fse.de> writes:
>
>
>> OK, seems I waited enough for comments. So, I will make int(11) bigint
>> and have EXPIRATION_DATE as bigint as well, thus allowing to remove
>> modifications in MySqlAdapter.
>>
>>
>> 30 minutes to stop me now...
>
> Nice thing about cvs, we can alway undo changes. No reason to wait
> an other 30 minutes.

Commit then review, Oliver, believe me, it works! it really does :-)

--
Stefano.

Re: cvs commit: jakarta-slide/proposals/stores/org/apache/slide/s tore/impl/rdbms MySqlSchema.sql

Posted by Martin Holz <ho...@fiz-chemie.de>.
Oliver Zeigermann <oz...@c1-fse.de> writes:


> OK, seems I waited enough for comments. So, I will make int(11) bigint
> and have EXPIRATION_DATE as bigint as well, thus allowing to remove
> modifications in MySqlAdapter.
> 
> 
> 30 minutes to stop me now...

Nice thing about cvs, we can alway undo changes. No reason to wait
an other 30 minutes. 

Martin 


---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org