You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/29 13:17:50 UTC

[GitHub] [flink] zhuzhurk commented on a change in pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly

zhuzhurk commented on a change in pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly
URL: https://github.com/apache/flink/pull/10341#discussion_r352127165
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
 ##########
 @@ -656,16 +658,17 @@ public void testNotSupportInputSelectableOperatorIfCheckpointing() {
 
 	@Test
 	public void testManagedMemoryFractionForSpecifiedResourceSpec() throws Exception {
+		// these specific values are needed to produce the double precision issues
 
 Review comment:
   updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services