[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280265#comment-16280265 ] 

ASF GitHub Bot commented on FLINK-8087:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5088#discussion_r155258087
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotsTestImplContext.java ---
    @@ -31,7 +30,7 @@
     import static org.mockito.Mockito.mock;
     import static org.mockito.Mockito.when;
     
    -public class AllocatedSlotsTest {
    +public class SlotsTestImplContext {
    --- End diff --
    
    Why was this renamed?


> Decouple Slot from SlotPool
> ---------------------------
>
>                 Key: FLINK-8087
>                 URL: https://issues.apache.org/jira/browse/FLINK-8087
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> In order to let the {{SlotPool}} return a a different {{LogicalSlot}} implementation than {{SimpleSlot}} we should not store the {{Slot}} inside of the {{SlotPool}}. Moreover, we should introduce a abstraction for the {{AllocatedSlot}} which contains the information required by the {{SimpleSlot}}. That way we decouple the {{SimpleSlot}} from the {{AllocatedSlot}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)