You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/31 19:13:30 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2247: Impl FromIterator for Decimal256Array

viirya commented on code in PR #2247:
URL: https://github.com/apache/arrow-rs/pull/2247#discussion_r934027894


##########
arrow/src/array/array_decimal.rs:
##########
@@ -219,6 +222,16 @@ pub trait BasicDecimalArray<T: BasicDecimal, U: From<ArrayData>>:
         let array_data = unsafe { builder.build_unchecked() };
         U::from(array_data)
     }
+
+    /// The default precision and scale used when not specified.
+    fn default_type() -> DataType {
+        // Keep maximum precision

Review Comment:
   trait function cannot be `const`. I changed it to be a `const` value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org