You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nicolás Lichtmaier <ni...@reloco.com.ar> on 2006/07/10 22:27:37 UTC

[PATCH] Ability to disable automatic WC upgrades from configure.

May I commit this? Thanks!


Re: [PATCH] Ability to disable automatic WC upgrades from configure.

Posted by Nicolás Lichtmaier <ni...@reloco.com.ar>.
>>> This was discussed when the code was added:
>>>
>>> http://svn.haxx.se/dev/archive-2006-04/0326.shtml
>>>
>>> Is it a good idea to make it user visible?  Why is it "useful for
>>> development"?
>>>       
>> It's useful for having the stable version alongside the trunk version
>> without accidentally making WCs unusable for the former. Any user
>> could want to have a trunk development to peep wht's going on in
>> Subversion, or for developing his own subversion client, or
>> whatever.
>>     
> That explains why SVN_DISABLE_WC_UPGRADE is useful, I'm not arguing
> against that.  Why do you need a specific configure option?  Why is
> the general method of setting compiler flags not enough?
>
>   
>> Compiling users are a special kind of "end users".
>>
>> Anyway, it's as useful as --enable-debug, --enable-gprof, which should
>> be removed if you want to be consistent with your view.
>>     
>
> I'd get rid of those too :)
>   

Ok, is a matter of opinion. I'd put it, but it's not so important. I can 
live with my modified configure.in =).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Ability to disable automatic WC upgrades from configure.

Posted by Philip Martin <ph...@codematters.co.uk>.
Nicolás Lichtmaier <ni...@reloco.com.ar> writes:

>>> [[[
>>> Ability to disable automatic WC upgrades from configure.
>>>
>> This was discussed when the code was added:
>>
>> http://svn.haxx.se/dev/archive-2006-04/0326.shtml
>>
>> Is it a good idea to make it user visible?  Why is it "useful for
>> development"?
>
> It's useful for having the stable version alongside the trunk version
> without accidentally making WCs unusable for the former. Any user
> could want to have a trunk development to peep wht's going on in
> Subversion, or for developing his own subversion client, or
> whatever.

That explains why SVN_DISABLE_WC_UPGRADE is useful, I'm not arguing
against that.  Why do you need a specific configure option?  Why is
the general method of setting compiler flags not enough?

> Compiling users are a special kind of "end users".
>
> Anyway, it's as useful as --enable-debug, --enable-gprof, which should
> be removed if you want to be consistent with your view.

I'd get rid of those too :)

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: [PATCH] Ability to disable automatic WC upgrades from configure.

Posted by Nicolás Lichtmaier <ni...@reloco.com.ar>.
>> [[[
>> Ability to disable automatic WC upgrades from configure.
>>     
> This was discussed when the code was added:
>
> http://svn.haxx.se/dev/archive-2006-04/0326.shtml
>
> Is it a good idea to make it user visible?  Why is it "useful for
> development"?
>   

It's useful for having the stable version alongside the trunk version 
without accidentally making WCs unusable for the former. Any user could 
want to have a trunk development to peep wht's going on in Subversion, 
or for developing his own subversion client, or whatever. Compiling 
users are a special kind of "end users".

Anyway, it's as useful as --enable-debug, --enable-gprof, which should 
be removed if you want to be consistent with your view.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Ability to disable automatic WC upgrades from configure.

Posted by Philip Martin <ph...@codematters.co.uk>.
Nicolás Lichtmaier <ni...@reloco.com.ar> writes:

> May I commit this? Thanks!
>
> [[[
> Ability to disable automatic WC upgrades from configure.
>
> * subversion/configure.in: Add --disable-wc-upgrades which defines
>   SVN_DISABLE_WC_UPGRADE, so that automatic WC upgrades are disabled. This
>   is useful for development.

This was discussed when the code was added:

http://svn.haxx.se/dev/archive-2006-04/0326.shtml

Is it a good idea to make it user visible?  Why is it "useful for
development"?

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: [PATCH] Ability to disable automatic WC upgrades from configure.

Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Mon, Jul 10, 2006 at 07:27:37PM -0300, Nicolás Lichtmaier wrote:
> Ability to disable automatic WC upgrades from configure.
> 
> * subversion/configure.in: Add --disable-wc-upgrades which defines
>   SVN_DISABLE_WC_UPGRADE, so that automatic WC upgrades are disabled. This
>   is useful for development.

As was pointed out to me when I originally created the #define, you
can use something like './configure CFLAGS=-DSVN_DISABLE_WC_UPGRADE'
to achieve this.  About the only thing this gains is visibility, but
there were some objections at the time about adding not-generally-useful
options to configure.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org