[jira] [Commented] (YARN-4090) Make Collections.sort() more efficient in FSParentQueue.java

["Yufei Gu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280653#comment-15280653 ] 

Yufei Gu commented on YARN-4090:
--------------------------------

Thanks, [~xinxianyin]! Looks really good. All three previous test failures are
solved. The override of {{move()}} is a reasonable solution. 

Minor nit, do you mean "bring down" or "decrease" when you said "write
down" in this comment? 
<quote>
      // do not decResource when the container exited in the preemptionMap
      // before because we have written down the resource when adding the
      // container to preemptionMap in this#addPreemption.
<quote>  
[~kasha], wanna take a look?

> Make Collections.sort() more efficient in FSParentQueue.java
> ------------------------------------------------------------
>
>                 Key: YARN-4090
>                 URL: https://issues.apache.org/jira/browse/YARN-4090
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Xianyin Xin
>            Assignee: Xianyin Xin
>         Attachments: YARN-4090-TestResult.pdf, YARN-4090-preview.patch, YARN-4090.001.patch, sampling1.jpg, sampling2.jpg
>
>
> Collections.sort() consumes too much time in a scheduling round.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org