You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "dombizita (via GitHub)" <gi...@apache.org> on 2023/02/24 11:18:29 UTC

[GitHub] [ozone] dombizita opened a new pull request, #4312: HDDS-8023. [HTTPFSGW] Remove support for satisfyStoragePolicy operation

dombizita opened a new pull request, #4312:
URL: https://github.com/apache/ozone/pull/4312

   ## What changes were proposed in this pull request?
   
   I removed the support for satisfyStoragePolicy operation. 
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8023
   
   ## How was this patch tested?
   
   Built the project successfully, CI on my fork: https://github.com/dombizita/ozone/actions/runs/4258119003
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] fapifta merged pull request #4312: HDDS-8023. [HTTPFSGW] Remove support for satisfyStoragePolicy operation

Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta merged PR #4312:
URL: https://github.com/apache/ozone/pull/4312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] dombizita commented on pull request #4312: HDDS-8023. [HTTPFSGW] Remove support for satisfyStoragePolicy operation

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #4312:
URL: https://github.com/apache/ozone/pull/4312#issuecomment-1445376159

   > Thanks Zita for working on this. It's looking good to me, I just have 1 question/remark. `SATISFYSTORAGEPOLICY` enum value is no longer used for practical purposes only for throwing the UnsupportedOperationException. Is it still needed, or is it possible to remove that operation entirely? I'm not too familiar with how HTTPFS works, and what side effects it could have.
   
   hi @Galsza, thanks for the review! we decided to keep `SATISFYSTORAGEPOLICY` as it is a valid operation in WebHDFS, check [here](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/WebHDFS.html#Satisfy_Storage_Policy), so we want to throw a specific exception in that case, as it is not just a general not supported operation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] Galsza commented on pull request #4312: HDDS-8023. [HTTPFSGW] Remove support for satisfyStoragePolicy operation

Posted by "Galsza (via GitHub)" <gi...@apache.org>.
Galsza commented on PR #4312:
URL: https://github.com/apache/ozone/pull/4312#issuecomment-1443741170

   Thanks Zita for working on this. It's looking good to me, I just have 1 question/remark.
   `SATISFYSTORAGEPOLICY` enum value is no longer used except in `HttpFSParametersProvider` Is it still needed, or could you remove it? I'm not too familiar with how HTTPFS works, and what side effects it would have if we removed that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org