[GitHub] [incubator-livy] Tagar commented on a change in pull request #151: [LIVY-566] When cancel a sql job through livy, actually the sparkjob still running

[GitBox <gi...@apache.org>]

Tagar commented on a change in pull request #151: [LIVY-566] When cancel a sql job through livy, actually the sparkjob still running 
URL: https://github.com/apache/incubator-livy/pull/151#discussion_r264307407
 
 

 ##########
 File path: thriftserver/session/src/main/java/org/apache/livy/thriftserver/session/SqlJob.java
 ##########
 @@ -59,7 +59,7 @@ public SqlJob(
 
   @Override
   public Void call(JobContext ctx) throws Exception {
-    ctx.sc().setJobGroup(statementId, statement);
+    ctx.sc().setJobGroup(statementId, statement)
 
 Review comment:
   Is setting job description as statement text related to LIVY-566? 
   If yes, job description might need to be set to something else? as statement text can contain sensitive information. 
   Thanks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services