You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/01 20:48:00 UTC
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] asgardner opened a new pull request #21: Add tsaurl and tsacert options when signing nbms
asgardner opened a new pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21
When signing NBMs, the Ant task supports adding both TSA certifcates and TSA URLs to timestamp the signed jar/nbm. This change adds the parameters, reads them if they exist, and then calls the methods to add them to the Ant task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1062694476
Hi, no needs for test, is it possible for you to squash. Should be ok to merge then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] asgardner commented on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
asgardner commented on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1059438193
I will look at the format to make sure it matches. Sorry about that. I do confirm that this change is my own work and that it's contributed solely under the terms of the Apache License 2.0. The git log looks good, although I could have given a better commit message. I'm going to add a unit test. I am a first time contributor, but I don't think this is an "important modification" that requires an ICLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1066690320
Hi, thanks for the squash I merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] asgardner commented on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
asgardner commented on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1062408611
I've pushed a second commit that brings the code in line with the format of the rest of the file. The change has been tested externally. Code signing isn't tested in the current unit test AFAIK, so the effort required to add an appropriate test seems out of balance with the size of the change. If that isn't the case, let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] asgardner commented on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
asgardner commented on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1063087457
Squashed. Thanks for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni merged pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni edited a comment on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
ebarboni edited a comment on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1058004701
Hi @asgardner I think the proposal is good and simple (maybe format issue )just as you are new to the repo and maybe on Apache NetBeans releated repo you have to take the following in consideration:
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1058004701
Hi @asgardner I think the proposal is good and simple (maybe format issue )just as you are new to the repo and maybe on Apache NetBeans releated repo you have to take the following in consideration:
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
are all your own work, and you have the right to contribute them.
are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] asgardner edited a comment on pull request #21: Add tsaurl and tsacert options when signing nbms
Posted by GitBox <gi...@apache.org>.
asgardner edited a comment on pull request #21:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/21#issuecomment-1059438193
I will look at the format to make sure it matches. Sorry about that. I do confirm that this change is my own work and that it's contributed solely under the terms of the Apache License 2.0. The git log looks good, although I could have given a better commit message. I am a first time contributor, but I don't think this is an "important modification" that requires an ICLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists