[GitHub] [incubator-druid] SandishKumarHN commented on a change in pull request #8394: #8156 : StructuralSearchInspection, Prohibit check on Thread.getState()

[GitBox <gi...@apache.org>]

SandishKumarHN commented on a change in pull request #8394: #8156 : StructuralSearchInspection, Prohibit check on Thread.getState()
URL: https://github.com/apache/incubator-druid/pull/8394#discussion_r326886216
 
 

 ##########
 File path: core/src/test/java/org/apache/druid/testing/DeadlockDetectingFailOnTimeout.java
 ##########
 @@ -194,13 +194,17 @@ private Thread getStuckThread(Thread mainThread)
     Thread stuckThread = null;
     long maxCpuTime = 0;
     for (Thread thread : threadsInGroup) {
-      if (thread.getState() == Thread.State.RUNNABLE) {
+      try {
+        thread.join();
 
 Review comment:
   @leventov yup, we need to SuppressWarnings for this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org