You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by tison <wa...@gmail.com> on 2023/06/02 01:11:03 UTC
[DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Hi,
Here is some background - [1][2].
Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
request branches" for pulsar-site GitHub repo. We did the same for the main
repo while reverting later. Now INFRA team members want to see an explicit
consensus among the community to do so for the site repo.
Thus, I come here to ask you to share your thoughts sincerely.
Thank you!
Best,
tison.
[1] https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
[2] https://issues.apache.org/jira/browse/INFRA-24636
Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Posted by Zili Chen <ti...@apache.org>.
FYI - the proposal is applied https://issues.apache.org/jira/browse/INFRA-24636.
On 2023/06/02 02:25:55 Dave Fisher wrote:
> I think that INFRA would accept a DISCUSSION that looks for LAZY CONSENSUS.
>
> Sent from my iPhone
>
> > On Jun 1, 2023, at 7:18 PM, tison <wa...@gmail.com> wrote:
> >
> > While we can vote for these two simultaneously to ask for INFRA members to
> > enable them at once. I agree that it can help since PRs is more open than
> > commit only changes - I experience that even in a review after merge
> > pattern a PR is more easily to get comments and response while commits are
> > always overwhelmed.
> >
> > Best,
> > tison.
> >
> >
> > tison <wa...@gmail.com> 于2023年6月2日周五 10:15写道：
> >
> >>> I committed a change directly to the main branch when I was expecting
> >> to be forced to create a PR.
> >>
> >> This seems a different topic.
> >>
> >> What we're talking about is "Always suggest updating pull request branches
> >> ",
> >>
> >> ... while you're referring to "Require a pull request before merging".
> >>
> >> Best,
> >> tison.
> >>
> >>
> >> Dave Fisher <wa...@comcast.net> 于2023年6月2日周五 10:10写道：
> >>
> >>> I committed a change directly to the main branch when I was expecting to
> >>> be forced to create a PR.
> >>>
> >>> There are times when a quick commit can make life easier, but PRs make it
> >>> easier to follow changes.
> >>>
> >>> Best,
> >>> Dave
> >>>
> >>> Sent from my iPhone
> >>>
> >>>>> On Jun 1, 2023, at 6:12 PM, tison <wa...@gmail.com> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> Here is some background - [1][2].
> >>>>>
> >>>>> Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
> >>>>> request branches" for pulsar-site GitHub repo. We did the same for the
> >>> main
> >>>> repo while reverting later. Now INFRA team members want to see an
> >>> explicit
> >>>> consensus among the community to do so for the site repo.
> >>>>
> >>>> Thus, I come here to ask you to share your thoughts sincerely.
> >>>>
> >>>> Thank you!
> >>>>
> >>>> Best,
> >>>> tison.
> >>>>
> >>>> [1]
> >>> https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
> >>>> [2] https://issues.apache.org/jira/browse/INFRA-24636
> >>>
> >>>
>
Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Posted by tison <wa...@gmail.com>.
OK. Let me share the updates to INFRA members then.
BTW, I saw this direct commit that may be better to go through a PR for
better visibility :D
-
https://github.com/apache/pulsar-site/commit/04d5b02c48a7a49f9159d8c6f5c82e2537ae2caa
Best,
tison.
Dave Fisher <wa...@comcast.net> 于2023年6月2日周五 10:26写道：
> I think that INFRA would accept a DISCUSSION that looks for LAZY CONSENSUS.
>
> Sent from my iPhone
>
> > On Jun 1, 2023, at 7:18 PM, tison <wa...@gmail.com> wrote:
> >
> > While we can vote for these two simultaneously to ask for INFRA members
> to
> > enable them at once. I agree that it can help since PRs is more open than
> > commit only changes - I experience that even in a review after merge
> > pattern a PR is more easily to get comments and response while commits
> are
> > always overwhelmed.
> >
> > Best,
> > tison.
> >
> >
> > tison <wa...@gmail.com> 于2023年6月2日周五 10:15写道：
> >
> >>> I committed a change directly to the main branch when I was expecting
> >> to be forced to create a PR.
> >>
> >> This seems a different topic.
> >>
> >> What we're talking about is "Always suggest updating pull request
> branches
> >> ",
> >>
> >> ... while you're referring to "Require a pull request before merging".
> >>
> >> Best,
> >> tison.
> >>
> >>
> >> Dave Fisher <wa...@comcast.net> 于2023年6月2日周五 10:10写道：
> >>
> >>> I committed a change directly to the main branch when I was expecting
> to
> >>> be forced to create a PR.
> >>>
> >>> There are times when a quick commit can make life easier, but PRs make
> it
> >>> easier to follow changes.
> >>>
> >>> Best,
> >>> Dave
> >>>
> >>> Sent from my iPhone
> >>>
> >>>>> On Jun 1, 2023, at 6:12 PM, tison <wa...@gmail.com> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> Here is some background - [1][2].
> >>>>>
> >>>>> Briefly, @dave2wave and I agree on Enable "Always suggest updating
> pull
> >>>>> request branches" for pulsar-site GitHub repo. We did the same for
> the
> >>> main
> >>>> repo while reverting later. Now INFRA team members want to see an
> >>> explicit
> >>>> consensus among the community to do so for the site repo.
> >>>>
> >>>> Thus, I come here to ask you to share your thoughts sincerely.
> >>>>
> >>>> Thank you!
> >>>>
> >>>> Best,
> >>>> tison.
> >>>>
> >>>> [1]
> >>> https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
> >>>> [2] https://issues.apache.org/jira/browse/INFRA-24636
> >>>
> >>>
>
Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Posted by Dave Fisher <wa...@comcast.net>.
I think that INFRA would accept a DISCUSSION that looks for LAZY CONSENSUS.
Sent from my iPhone
> On Jun 1, 2023, at 7:18 PM, tison <wa...@gmail.com> wrote:
>
> While we can vote for these two simultaneously to ask for INFRA members to
> enable them at once. I agree that it can help since PRs is more open than
> commit only changes - I experience that even in a review after merge
> pattern a PR is more easily to get comments and response while commits are
> always overwhelmed.
>
> Best,
> tison.
>
>
> tison <wa...@gmail.com> 于2023年6月2日周五 10:15写道：
>
>>> I committed a change directly to the main branch when I was expecting
>> to be forced to create a PR.
>>
>> This seems a different topic.
>>
>> What we're talking about is "Always suggest updating pull request branches
>> ",
>>
>> ... while you're referring to "Require a pull request before merging".
>>
>> Best,
>> tison.
>>
>>
>> Dave Fisher <wa...@comcast.net> 于2023年6月2日周五 10:10写道：
>>
>>> I committed a change directly to the main branch when I was expecting to
>>> be forced to create a PR.
>>>
>>> There are times when a quick commit can make life easier, but PRs make it
>>> easier to follow changes.
>>>
>>> Best,
>>> Dave
>>>
>>> Sent from my iPhone
>>>
>>>>> On Jun 1, 2023, at 6:12 PM, tison <wa...@gmail.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Here is some background - [1][2].
>>>>>
>>>>> Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
>>>>> request branches" for pulsar-site GitHub repo. We did the same for the
>>> main
>>>> repo while reverting later. Now INFRA team members want to see an
>>> explicit
>>>> consensus among the community to do so for the site repo.
>>>>
>>>> Thus, I come here to ask you to share your thoughts sincerely.
>>>>
>>>> Thank you!
>>>>
>>>> Best,
>>>> tison.
>>>>
>>>> [1]
>>> https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
>>>> [2] https://issues.apache.org/jira/browse/INFRA-24636
>>>
>>>
Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Posted by tison <wa...@gmail.com>.
While we can vote for these two simultaneously to ask for INFRA members to
enable them at once. I agree that it can help since PRs is more open than
commit only changes - I experience that even in a review after merge
pattern a PR is more easily to get comments and response while commits are
always overwhelmed.
Best,
tison.
tison <wa...@gmail.com> 于2023年6月2日周五 10:15写道：
> > I committed a change directly to the main branch when I was expecting
> to be forced to create a PR.
>
> This seems a different topic.
>
> What we're talking about is "Always suggest updating pull request branches
> ",
>
> ... while you're referring to "Require a pull request before merging".
>
> Best,
> tison.
>
>
> Dave Fisher <wa...@comcast.net> 于2023年6月2日周五 10:10写道：
>
>> I committed a change directly to the main branch when I was expecting to
>> be forced to create a PR.
>>
>> There are times when a quick commit can make life easier, but PRs make it
>> easier to follow changes.
>>
>> Best,
>> Dave
>>
>> Sent from my iPhone
>>
>> > On Jun 1, 2023, at 6:12 PM, tison <wa...@gmail.com> wrote:
>> >
>> > Hi,
>> >
>> > Here is some background - [1][2].
>> >
>> > Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
>> > request branches" for pulsar-site GitHub repo. We did the same for the
>> main
>> > repo while reverting later. Now INFRA team members want to see an
>> explicit
>> > consensus among the community to do so for the site repo.
>> >
>> > Thus, I come here to ask you to share your thoughts sincerely.
>> >
>> > Thank you!
>> >
>> > Best,
>> > tison.
>> >
>> > [1]
>> https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
>> > [2] https://issues.apache.org/jira/browse/INFRA-24636
>>
>>
Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Posted by tison <wa...@gmail.com>.
> I committed a change directly to the main branch when I was expecting to
be forced to create a PR.
This seems a different topic.
What we're talking about is "Always suggest updating pull request branches
",
... while you're referring to "Require a pull request before merging".
Best,
tison.
Dave Fisher <wa...@comcast.net> 于2023年6月2日周五 10:10写道：
> I committed a change directly to the main branch when I was expecting to
> be forced to create a PR.
>
> There are times when a quick commit can make life easier, but PRs make it
> easier to follow changes.
>
> Best,
> Dave
>
> Sent from my iPhone
>
> > On Jun 1, 2023, at 6:12 PM, tison <wa...@gmail.com> wrote:
> >
> > Hi,
> >
> > Here is some background - [1][2].
> >
> > Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
> > request branches" for pulsar-site GitHub repo. We did the same for the
> main
> > repo while reverting later. Now INFRA team members want to see an
> explicit
> > consensus among the community to do so for the site repo.
> >
> > Thus, I come here to ask you to share your thoughts sincerely.
> >
> > Thank you!
> >
> > Best,
> > tison.
> >
> > [1]
> https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
> > [2] https://issues.apache.org/jira/browse/INFRA-24636
>
>
Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site
Posted by Dave Fisher <wa...@comcast.net>.
I committed a change directly to the main branch when I was expecting to be forced to create a PR.
There are times when a quick commit can make life easier, but PRs make it easier to follow changes.
Best,
Dave
Sent from my iPhone
> On Jun 1, 2023, at 6:12 PM, tison <wa...@gmail.com> wrote:
>
> Hi,
>
> Here is some background - [1][2].
>
> Briefly, @dave2wave and I agree on Enable "Always suggest updating pull
> request branches" for pulsar-site GitHub repo. We did the same for the main
> repo while reverting later. Now INFRA team members want to see an explicit
> consensus among the community to do so for the site repo.
>
> Thus, I come here to ask you to share your thoughts sincerely.
>
> Thank you!
>
> Best,
> tison.
>
> [1] https://github.com/apache/pulsar-site/pull/543#issuecomment-1562151294
> [2] https://issues.apache.org/jira/browse/INFRA-24636