You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2025/02/26 22:41:46 UTC

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22555


Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................

IMPALA-13671: Add Additional Debug Output

The custom_cluster/test_workload_mgmt_init.py tests failed with a
mismatch between the expected and actual start time. The error that
is logged only says "start time incorrect".

This patch adds the expected and actual query start time values to
the assertion failed message.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
---
M tests/util/workload_management.py
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/22555/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 19:01:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18423/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 18:10:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11534/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 20:19:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18425/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 19:09:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22555/1/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22555/1/tests/util/workload_management.py@203
PS1, Line 203: tc_offset
> Repeated string.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 17:44:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22555/1/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22555/1/tests/util/workload_management.py@203
PS1, Line 203: "%Y-%m-%d %H:%M:%S.%f"
Repeated string.
Please make it a constant and reuse it.



-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:19:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18400/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:08:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 01:46:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:48:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22555

to look at the new patch set (#3).

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................

IMPALA-13671: Add Additional Debug Output

The custom_cluster/test_workload_mgmt_init.py tests failed with a
mismatch between the expected and actual start time. The error that
is logged only says "start time incorrect".

This patch adds the expected and actual query start time values to
the assertion failed message.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
---
M tests/util/workload_management.py
1 file changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/22555/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................

IMPALA-13671: Add Additional Debug Output

The custom_cluster/test_workload_mgmt_init.py tests failed with a
mismatch between the expected and actual start time. The error that
is logged only says "start time incorrect".

This patch adds the expected and actual query start time values to
the assertion failed message.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Reviewed-on: http://gerrit.cloudera.org:8080/22555
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/util/workload_management.py
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 18:27:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22555

to look at the new patch set (#2).

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................

IMPALA-13671: Add Additional Debug Output

The custom_cluster/test_workload_mgmt_init.py tests failed with a
mismatch between the expected and actual start time. The error that
is logged only says "start time incorrect".

This patch adds the expected and actual query start time values to
the assertion failed message.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
---
M tests/util/workload_management.py
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/22555/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13671: Add Additional Debug Output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22555 )

Change subject: IMPALA-13671: Add Additional Debug Output
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb1627ea719f0e20459ba6052685320a169d5176
Gerrit-Change-Number: 22555
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 20:19:53 +0000
Gerrit-HasComments: No