You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/07 06:41:42 UTC

[GitHub] [pulsar] Jason918 commented on a diff in pull request #16420: [fix][broker] fix No such ledger exception

Jason918 commented on code in PR #16420:
URL: https://github.com/apache/pulsar/pull/16420#discussion_r915512032


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -1562,6 +1562,20 @@ private void updateLedgersListAfterRollover(MetaStoreCallback<Void> callback) {
         store.asyncUpdateLedgerIds(name, getManagedLedgerInfo(), ledgersStat, callback);
     }
 
+    private void updateLedgersListAfterRollover(MetaStoreCallback<Void> callback, ManagedLedgerInfo mlInfo) {

Review Comment:
   It seems we can just modify in previous method `updateLedgersListAfterRollover`, not creating new one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org