You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2016/03/12 00:11:12 UTC
[GitHub] incubator-madlib pull request: Elastic Net: Skip arrays with NULL ...
GitHub user njayaram2 opened a pull request:
https://github.com/apache/incubator-madlib/pull/31
Elastic Net: Skip arrays with NULL values in predict
Jira: MADLIB-919
Having NULL values in the input array led to an error while converting the array to a MappedColumnVector. This fix now skips prediction for arrays with NULL values. This also includes new test cases to the install check of elastic net.
@iyerr3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/njayaram2/incubator-madlib elastic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit df9fd0d4ada76d0bf9b3c9632dfe6bd86533237e
Author: Nandish Jayaram <nj...@pivotal.io>
Date: 2016-03-11T22:58:48Z
Elastic Net: Skip arrays with NULL values in predict
Jira: MADLIB-919
Having NULL values in the input array led to an error while converting the array to a MappedColumnVector. This fix now skips prediction for arrays with NULL values. This also includes new test cases to the install check of elastic net.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request: Elastic Net: Skip arrays with NULL ...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on the pull request:
https://github.com/apache/incubator-madlib/pull/31#issuecomment-195599724
General comment: Try to keep the commit title under 50 chars and definitely keep the body text under 72 chars. See Tim Pope's blog for [good commit messaging habits.](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request: Elastic Net: Skip arrays with NULL ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---