You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/11/15 08:39:11 UTC
[GitHub] zeppelin pull request #1635: [WIP] - ZeppelinHubNotebookRepo multy user hand...
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1635
[WIP] - ZeppelinHubNotebookRepo multy user handling
### What is this PR for?
This PR bring multi user handling to ZeppelinHubNotebookRepo.
### What type of PR is it?
[Improvement ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin feat/ZeppelinHubRepoMultiUser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1635.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1635
----
commit 0729f5197176515399df7c6bcb81ceb910637ebe
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T09:49:54Z
Add zeppelinhub session container
commit 7a0c9594e0ad7587de8699e4daef8d394af0e612
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T10:39:31Z
Add zeppelinhub user session to userSession container after login throght zeppelinhubRealm
commit e3e5a15bee6dfdd1bf960cf3ff648ae464612179
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T10:42:37Z
Add userTiket in AuthenticationInfo on OnMessage method in notebookServer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1635: [ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy user h...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1635
thanks for the fix, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1635: [WIP] - ZeppelinHubNotebookRepo multy user handling
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1635
@khalidhuseynov as you can see its a wip, i will let you know when its ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1635: [ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1635: [WIP] - ZeppelinHubNotebookRepo multy user handling
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1635
@anthonycorbacho thanks for enhancements! i started looking into this one and first of all CI looks like failing with checkstyle issues. Also some methods seem to be missing, and proper jira ticket would be appreciated :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1635: [ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy user h...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1635
CI is green, please review otherwise merging it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1635: [ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1635: [ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy...
Posted by anthonycorbacho <gi...@git.apache.org>.
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1635
[ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy user handling
### What is this PR for?
This PR bring multi user handling to ZeppelinHubNotebookRepo.
### What type of PR is it?
[Improvement ]
### What is the Jira issue?
* [ZEPPELIN-1690](https://issues.apache.org/jira/browse/ZEPPELIN-1690)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin feat/ZeppelinHubRepoMultiUser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1635.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1635
----
commit 0729f5197176515399df7c6bcb81ceb910637ebe
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T09:49:54Z
Add zeppelinhub session container
commit 7a0c9594e0ad7587de8699e4daef8d394af0e612
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T10:39:31Z
Add zeppelinhub user session to userSession container after login throght zeppelinhubRealm
commit e3e5a15bee6dfdd1bf960cf3ff648ae464612179
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T10:42:37Z
Add userTiket in AuthenticationInfo on OnMessage method in notebookServer
commit 67051a08d92e6f7e17a2379ba1693c58e89c4223
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-14T10:47:59Z
Add ZeppelinHub instance model
commit 5931ab693e3d26546df3f4b4262fe2454ae67fec
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-16T09:47:12Z
Fix check style
commit a8aeb51899d0c9528d65b447071f9c0ed59ab070
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-18T16:56:47Z
add comment in zeppelinhubRealm about saving user session in a singleton map
commit 3fbfcfa4e5343c22e4bb4da0484c23bf5296b3a2
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-18T17:04:46Z
Add new login on how user can get his token at runtime
commit 674fb93391d7af548affbccb3199fd470cc3b0dc
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-18T18:16:53Z
Refactor ZeppelinHub rest API handler
- Now takes a token on every http request
commit 25f6215a27a21be787f96f05eaa7e1b512a8d8a1
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-18T18:18:20Z
pass user token to zeppelinhub rest api handler
commit dbb8ebd98a0e52770acea2c5be0ce8e22a0a977b
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-18T18:18:35Z
Fix test
commit e88420319c7902091075283bfdb192b3a805871c
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-18T18:22:25Z
Refactor :: remove 'async' on every http call
commit edb9e8ce0da8a3de45c947ddb209de15bbd042e2
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-21T16:27:18Z
Desactivate ws :: we will need to refactor this part
commit aef6e00f3ff722651b80a246c62a7fd919df5f15
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-21T20:58:36Z
Fix check style
commit d8989aa45e2dbfac0c4d8e41798123a4a32a3526
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-22T14:30:20Z
Handle invalid subject
commit d9e003612d189300371cd98555e2bb3c1bcbd6d5
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-11-23T05:43:59Z
Move code location
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---