You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zihao Ye (Code Review)" <ge...@cloudera.org> on 2025/07/17 09:59:40 UTC

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure

Zihao Ye has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23181


Change subject: IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure
......................................................................

IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure

The existing code incorrectly drops the corresponding Kudu table when
the creation of a Kudu external table in HMS fails due to an erroneous
negation in the if condition.
Removed the incorrect negation in the if condition to align with the
intended behavior described in the comment.

Testing:
 - Existing tests cover this change.

Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/23181/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 5
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 12:25:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23181

to look at the new patch set (#3).

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................

IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

The existing code incorrectly attempts to drop the corresponding
Kudu table when the creation of a Kudu external table in HMS fails due
to an erroneous negation in the if condition (fortunately, there are
additional checks with Preconditions in KuduCatalogOpExecutor.dropTable,
causing such attempts to always fail).
Removed the incorrect negation in the if condition to align with the
intended behavior described in the comment.

Testing:
 - Existing tests cover this change.

Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/23181/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23181/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23181/2//COMMIT_MSG@9
PS2, Line 9: drattempts
> nit: "attempts"?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 09:44:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 4
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 12:25:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12302/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 5
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 12:25:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23181

to look at the new patch set (#2).

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................

IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

The existing code incorrectly drattempts to dropops the corresponding
Kudu table when the creation of a Kudu external table in HMS fails due
to an erroneous negation in the if condition (fortunately, there are
additional checks with Preconditions in KuduCatalogOpExecutor.dropTable,
causing such attempts to always fail).
Removed the incorrect negation in the if condition to align with the
intended behavior described in the comment.

Testing:
 - Existing tests cover this change.

Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/23181/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure
......................................................................


Patch Set 1:

(1 comment)

Thanks for catching this bug!

http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG@16
PS1, Line 16:  - Existing tests cover this change.
Is it possible to add a test using the steps you mentioned in the JIRA? To be simple, we can add a debug action to inject failures before invoking the HMS RPC.



-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 10:34:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................

IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

The existing code incorrectly attempts to drop the corresponding
Kudu table when the creation of a Kudu external table in HMS fails due
to an erroneous negation in the if condition (fortunately, there are
additional checks with Preconditions in KuduCatalogOpExecutor.dropTable,
causing such attempts to always fail). Additionally, when creating a
Kudu synchronized table, if the table creation fails in HMS, it will
unexpectedly skip deleting the corresponding Kudu table, resulting in an
"already exists in Kudu" error when retrying the table creation.

Removed the incorrect negation in the if condition to align with the
intended behavior described in the comment.

Testing:
 - Existing tests cover this change.

Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Reviewed-on: http://gerrit.cloudera.org:8080/23181
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 6
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 1:

(1 comment)

Thanks for the reviews!

http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG@16
PS1, Line 16:  - Existing tests cover this change.
> Is it possible to add a test using the steps you mentioned in the JIRA? To 
I have tried to add a test and found that the situation was not as bad as I had imagined because there are additional checks in KuduCatalogOpExecutor.dropTable to ensure that the Kudu table to be dropped is a synchronized table (https://github.com/apache/impala/blob/8a691a350756d7b2f854a9da0585adb944081c6f/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java#L325). Therefore, the severity of this issue is not that high, and the related tests do not seem necessary. I have updated the commit message to include this information.



-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 08:32:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop on external table creation failure
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19900/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 10:26:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23181

to look at the new patch set (#4).

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................

IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

The existing code incorrectly attempts to drop the corresponding
Kudu table when the creation of a Kudu external table in HMS fails due
to an erroneous negation in the if condition (fortunately, there are
additional checks with Preconditions in KuduCatalogOpExecutor.dropTable,
causing such attempts to always fail). Additionally, when creating a
Kudu synchronized table, if the table creation fails in HMS, it will
unexpectedly skip deleting the corresponding Kudu table, resulting in an
"already exists in Kudu" error when retrying the table creation.

Removed the incorrect negation in the if condition to align with the
intended behavior described in the comment.

Testing:
 - Existing tests cover this change.

Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/23181/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 4
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG@16
PS1, Line 16: 
> I have tried to add a test and found that the situation was not as bad as I
Ack


http://gerrit.cloudera.org:8080/#/c/23181/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23181/2//COMMIT_MSG@9
PS2, Line 9: drattempts
nit: "attempts"?



-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 09:39:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )

Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b
Gerrit-Change-Number: 23181
Gerrit-PatchSet: 5
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 18:01:44 +0000
Gerrit-HasComments: No