[GitHub] [samza] dnishimura commented on a change in pull request #1213: [WIP] SAMZA-2305: Stream processor should ensure previous container is stopped during a rebalance

[GitBox <gi...@apache.org>]

dnishimura commented on a change in pull request #1213: [WIP] SAMZA-2305: Stream processor should ensure previous container is stopped during a rebalance
URL: https://github.com/apache/samza/pull/1213#discussion_r343754616
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java
 ##########
 @@ -346,9 +352,10 @@ public void stop() {
         try {
           LOGGER.info("Shutting down the container: {} of stream processor: {}.", container, processorId);
           boolean hasContainerShutdown = stopSamzaContainer();
+          // todo: use interruptSamzaContainer method instead to give one more chance for container to shutdown
 
 Review comment:
   Why can't you use `interruptSamzaContainer()` now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services