[GitHub] [hudi] BruceKellan commented on a diff in pull request #5556: [HUDI-4083] Fix the flink application fails to start due to uncomplet…

[GitBox <gi...@apache.org>]

BruceKellan commented on code in PR #5556:
URL: https://github.com/apache/hudi/pull/5556#discussion_r871037257


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -515,13 +515,25 @@ private Stream<HoodieInstant> getInstantsToArchive() {
   private boolean deleteArchivedInstants(List<HoodieInstant> archivedInstants, HoodieEngineContext context) throws IOException {
     LOG.info("Deleting instants " + archivedInstants);
     boolean success = true;
-    List<String> instantFiles = archivedInstants.stream().map(archivedInstant ->
-        new Path(metaClient.getMetaPath(), archivedInstant.getFileName())

Review Comment:
   Yes, that's right. But I'm not sure if `deleteFilesParallelize` is cleaned in order. It use `FSUtils.parallelizeFilesProcess` to delete file and depend on implement in different engine.
   
   https://github.com/apache/hudi/blob/b10ca7e69f43cf2f14b09d0a610102ab058b1511/hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/common/HoodieFlinkEngineContext.java#L145-L147
   
   For example, in flink engine context, it use parallel stream to delete file. 
   This is my understanding, please ping me if I am wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org