[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #1118: fix(go/adbc): missing adbc.ingest.temporary

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #1118:
URL: https://github.com/apache/arrow-adbc/pull/1118#discussion_r1339065139


##########
go/adbc/adbc.go:
##########
@@ -237,6 +237,7 @@ const (
 	OptionKeyProgress                 = "adbc.statement.exec.progress"
 	OptionKeyMaxProgress              = "adbc.statement.exec.max_progress"
 	OptionKeyIngestTargetTable        = "adbc.ingest.target_table"
+	OptionKeyIngestTemporary          = "adbc.ingest.temporary"

Review Comment:
   We haven't technically added these options to the 'specification' interface



##########
go/adbc/driver/snowflake/statement.go:
##########
@@ -108,6 +108,11 @@ func (st *statement) SetOption(key string, val string) error {
 	case adbc.OptionKeyIngestTargetTable:
 		st.query = ""
 		st.targetTable = val
+	case adbc.OptionKeyIngestTemporary:
+		return adbc.Error{
+			Msg:  fmt.Sprintf("[Snowflake] Unknown statement option '%s'", key),
+			Code: adbc.StatusNotImplemented,
+		}

Review Comment:
   Is this really necessary? The default will do this already



##########
go/adbc/adbc.go:
##########
@@ -237,6 +237,7 @@ const (
 	OptionKeyProgress                 = "adbc.statement.exec.progress"
 	OptionKeyMaxProgress              = "adbc.statement.exec.max_progress"
 	OptionKeyIngestTargetTable        = "adbc.ingest.target_table"
+	OptionKeyIngestTemporary          = "adbc.ingest.temporary"

Review Comment:
   @zeroshade is there any way to mark things 'experimental'?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org