You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sis.apache.org by de...@apache.org on 2015/12/10 15:11:24 UTC
svn commit: r1719084 - in /sis/ip-review: AuthorityFactoryProxyTest.xhtml
rev/25050/AuthorityFactoryProxyTest.xhtml
Author: desruisseaux
Date: Thu Dec 10 14:11:24 2015
New Revision: 1719084
URL: http://svn.apache.org/viewvc?rev=1719084&view=rev
Log:
Add IP review for AuthorityFactoryProxyTest.
Added:
sis/ip-review/AuthorityFactoryProxyTest.xhtml (with props)
sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml (with props)
Added: sis/ip-review/AuthorityFactoryProxyTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/AuthorityFactoryProxyTest.xhtml?rev=1719084&view=auto
==============================================================================
--- sis/ip-review/AuthorityFactoryProxyTest.xhtml (added)
+++ sis/ip-review/AuthorityFactoryProxyTest.xhtml Thu Dec 10 14:11:24 2015
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>AuthorityFactoryProxyTest history</title>
+ <style type="text/css" media="all">
+ @import url("./reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>AuthorityFactoryProxyTest history</h1>
+ <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/AuthorityFactoryProxyTest.java</code></blockquote>
+<table>
+ <tr>
+ <th>Rev.</th>
+ <th>Date</th>
+ <th>Author</th>
+ <th class="last">Message</th>
+ </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright: Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">25396</td><td>2007-05-01</td><td>desruisseaux</td><td>GEOT-1160 now work with ordered axis (tests added). Added an implementation for fallback factories, but not yet tested.</td></tr>
+<tr><td class="rev">25374</td><td>2007-04-27</td><td>desruisseaux</td><td>More GEOT-1160 work: should now work with TransformedAuthorityFactory (not yet tested).</td></tr>
+<tr><td class="rev">25050</td><td>2007-04-06</td><td class="unav">jgarnett</td><td><a href="rev/25050/AuthorityFactoryProxyTest.xhtml">example of custom file based TestSutie, copy JTS parsing code over to unsupported/geometry</a></td></tr>
+<tr><td class="rev">24576</td><td>2007-02-24</td><td>desruisseaux</td><td>Renamed 'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming. Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique' was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match more closely the common usage. In addition, also renamed some JUnit test classes in an attempt to make clearer what they are testing.</td></tr>
+<tr><td class="rev">24384</td><td>2007-02-14</td><td>desruisseaux</td><td>GEOT-1160: First working implementation of AbstractAuthorityFactory.find(IdentifiedObject). This includes a package-privated AuthorityFactoryProxy class, together with many fix in the code base in order to get CRS.equalsIgnoreCase to work in the ProjectedCRS case.</td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/AuthorityFactoryProxyTest.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/AuthorityFactoryProxyTest.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html
Added: sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml?rev=1719084&view=auto
==============================================================================
--- sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml (added)
+++ sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml Thu Dec 10 14:11:24 2015
@@ -0,0 +1,67 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>AuthorityFactoryProxyTest changes for revisions 25049:25050</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>AuthorityFactoryProxyTest changes for revisions 25049:25050</h1>
+<p>
+ The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+ However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+ The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/AuthorityFactoryProxyTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>// Geotools dependencies
+import org.geotools.referencing.crs.*;
+import org.geotools.referencing.datum.*;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+
+
+/**</pre></td>
+<td><pre>// Geotools dependencies
+import org.geotools.referencing.crs.*;
+import org.geotools.referencing.datum.*;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre> * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreate() throws FactoryException {
+<span class="del"> final CRSAuthorityFactory factory = FactoryFinder.getCRSAuthorityFactory("CRS", null);</span>
+ final CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("83");
+ AuthorityFactoryProxy proxy;
+ /*</pre></td>
+<td><pre> * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreate() throws FactoryException {
+<span class="add"> final CRSAuthorityFactory factory = ReferencingFactoryFinder.getCRSAuthorityFactory("CRS", null);</span>
+ final CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("83");
+ AuthorityFactoryProxy proxy;
+ /*</pre></td></tr>
+<tr><td><pre> * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreateEquivalent() throws FactoryException {
+<span class="del"> final CRSAuthorityFactory factory = FactoryFinder.getCRSAuthorityFactory("CRS", null);</span>
+ final AuthorityFactoryProxy proxy = AuthorityFactoryProxy.getInstance(GeographicCRS.class, factory);
+ CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("84");
+ assertSame (expected, proxy.create("84"));</pre></td>
+<td><pre> * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreateEquivalent() throws FactoryException {
+<span class="add"> final CRSAuthorityFactory factory = ReferencingFactoryFinder.getCRSAuthorityFactory("CRS", null);</span>
+ final AuthorityFactoryProxy proxy = AuthorityFactoryProxy.getInstance(GeographicCRS.class, factory);
+ CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("84");
+ assertSame (expected, proxy.create("84"));</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Propchange: sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml
------------------------------------------------------------------------------
svn:mime-type = text/html