You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by skyluc <gi...@git.apache.org> on 2016/02/03 11:02:49 UTC

[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

GitHub user skyluc opened a pull request:

    https://github.com/apache/spark/pull/11047

    [SPARK-13002][Mesos] Send initial request of executors for dyn allocation

    Fix for [SPARK-13002](https://issues.apache.org/jira/browse/SPARK-13002) about the initial number of executors when running with dynamic allocation on Mesos.
    Instead of fixing it just for the Mesos case, made the change in `ExecutorAllocationManager`. It is already driving the number of executors running on Mesos, only no the initial value.
    
    The `None` and `Some(0)` are internal details on the computation of resources to reserved, in the Mesos backend scheduler. `executorLimitOption` has to be initialized correctly, otherwise the Mesos backend scheduler will, either, create to many executors at launch, or not create any executors and not be able to recover from this state.
    
    Removed the 'special case' description in the doc. It was not totally accurate, and is not needed anymore.
    
    This doesn't fix the same problem visible with Spark standalone. There is no straightforward way to send the initial value in standalone mode.
    
    Somebody knowing this part of the yarn support should review this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skyluc/spark issue/initial-dyn-alloc-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11047.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11047
    
----
commit 1c7594073267c8e0d4a58d7d4f6bd55df73d0316
Author: Luc Bourlier <lu...@typesafe.com>
Date:   2016-01-22T14:42:21Z

    Send initial request of executors for dyn allocation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179790970
  
    **[Test build #50747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50747/consoleFull)** for PR 11047 at commit [`8dda6bb`](https://github.com/apache/spark/commit/8dda6bb3b939a9d7cdc986080990435dd56f6591).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179190008
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50657/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by skyluc <gi...@git.apache.org>.
Github user skyluc commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179741301
  
    @andrewor14 yes, dynamic allocation works fine, but `spark.dynamicAllocation.initialExecutors` is not used at start-up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179748356
  
    **[Test build #50747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50747/consoleFull)** for PR 11047 at commit [`8dda6bb`](https://github.com/apache/spark/commit/8dda6bb3b939a9d7cdc986080990435dd56f6591).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by dragos <gi...@git.apache.org>.
Github user dragos commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179150956
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179147515
  
    **[Test build #50657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50657/consoleFull)** for PR 11047 at commit [`1c75940`](https://github.com/apache/spark/commit/1c7594073267c8e0d4a58d7d4f6bd55df73d0316).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179791483
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50747/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by skyluc <gi...@git.apache.org>.
Github user skyluc commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11047#discussion_r51846148
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -246,15 +246,15 @@ In either case, HDFS runs separately from Hadoop MapReduce, without being schedu
     
     # Dynamic Resource Allocation with Mesos
     
    -Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of executors based on statistics
    -of the application. While dynamic allocation supports both scaling up and scaling down the number of executors, the coarse grain scheduler only supports scaling down
    -since it is already designed to run one executor per slave with the configured amount of resources. However, after scaling down the number of executors the coarse grain scheduler
    -can scale back up to the same amount of executors when Spark signals more executors are needed.
    -
    -Users that like to utilize this feature should launch the Mesos Shuffle Service that
    -provides shuffle data cleanup functionality on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's
    -termination. To launch/stop the Mesos Shuffle Service please use the provided sbin/start-mesos-shuffle-service.sh and sbin/stop-mesos-shuffle-service.sh
    -scripts accordingly.
    +Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of
    +executors based on statistics of the application. For general information,
    +see [Dynamic Resource Allocation](job-scheduling.html#dynamic-resource-allocation).
    +
    +To be able to use the dynamic allocation support, an External Shuffle Service is required. 
    +On Mesos, users should launch the Mesos Shuffle Service. It provides shuffle data cleanup functionality
    --- End diff --
    
    The whole does add one piece of information: that a tweaked version of the External Shuffle service should be used, to have a full support in Mesos.
    I'll try to merge the 2 last paragraphs together.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179409983
  
    Once you address @mgummelt's comments I'll go ahead and merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179375397
  
    @vanzin isn't there already another place where we do this initial syncing? Does YARN have the same issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179370081
  
    @skyluc just so I understand the issue is not that dynamic allocation doesn't work, but rather `spark.dynamicAllocation.initialExecutors` doesn't take effect?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179369313
  
    @vanzin isn't there already another place where we do this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180439113
  
    **[Test build #50821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50821/consoleFull)** for PR 11047 at commit [`f5ab629`](https://github.com/apache/spark/commit/f5ab629fde5bd5520e367473160b708c7e23c535).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180428691
  
    **[Test build #50820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50820/consoleFull)** for PR 11047 at commit [`003e865`](https://github.com/apache/spark/commit/003e8658e78d372ab24919a6ce02d7bb85c91b70).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179791480
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180428980
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50820/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179990615
  
    (you might need to resolve a small conflict from my standalone patch...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180603329
  
    Merged into master. If there are more comments on the docs we can address them separately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by mgummelt <gi...@git.apache.org>.
Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11047#discussion_r51766078
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -246,15 +246,15 @@ In either case, HDFS runs separately from Hadoop MapReduce, without being schedu
     
     # Dynamic Resource Allocation with Mesos
     
    -Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of executors based on statistics
    -of the application. While dynamic allocation supports both scaling up and scaling down the number of executors, the coarse grain scheduler only supports scaling down
    -since it is already designed to run one executor per slave with the configured amount of resources. However, after scaling down the number of executors the coarse grain scheduler
    -can scale back up to the same amount of executors when Spark signals more executors are needed.
    -
    -Users that like to utilize this feature should launch the Mesos Shuffle Service that
    -provides shuffle data cleanup functionality on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's
    -termination. To launch/stop the Mesos Shuffle Service please use the provided sbin/start-mesos-shuffle-service.sh and sbin/stop-mesos-shuffle-service.sh
    -scripts accordingly.
    +Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of
    +executors based on statistics of the application. For general information,
    +see [Dynamic Resource Allocation](job-scheduling.html#dynamic-resource-allocation).
    +
    +To be able to use the dynamic allocation support, an External Shuffle Service is required. 
    +On Mesos, users should launch the Mesos Shuffle Service. It provides shuffle data cleanup functionality
    --- End diff --
    
    Saying they should run it "On Mesos" is a big confusing, since they don't technically need to.  They could run it out of band.  The instructions in the "Job Scheduling" page are pretty clear, so maybe we should say something like that here:
    
    In Mesos coarse-grained mode, run start-mesos-shuffle-service.sh on all slave nodes. For instance, you may do so through Marathon.
    
    I'd actually prefer leaving this entire paragraph out, since it just repeats instructions from the "Job Scheduling" page linked above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by dragos <gi...@git.apache.org>.
Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11047#discussion_r51875638
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -246,18 +246,13 @@ In either case, HDFS runs separately from Hadoop MapReduce, without being schedu
     
     # Dynamic Resource Allocation with Mesos
     
    -Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of executors based on statistics
    -of the application. While dynamic allocation supports both scaling up and scaling down the number of executors, the coarse grain scheduler only supports scaling down
    -since it is already designed to run one executor per slave with the configured amount of resources. However, after scaling down the number of executors the coarse grain scheduler
    -can scale back up to the same amount of executors when Spark signals more executors are needed.
    -
    -Users that like to utilize this feature should launch the Mesos Shuffle Service that
    -provides shuffle data cleanup functionality on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's
    -termination. To launch/stop the Mesos Shuffle Service please use the provided sbin/start-mesos-shuffle-service.sh and sbin/stop-mesos-shuffle-service.sh
    -scripts accordingly.
    -
    -The Shuffle Service is expected to be running on each slave node that will run Spark executors. One way to easily achieve this with Mesos
    -is to launch the Shuffle Service with Marathon with a unique host constraint.
    +Mesos supports dynamic allocation only with coarse-grain mode, which can resize the number of
    +executors based on statistics of the application. For general information,
    +see [Dynamic Resource Allocation](job-scheduling.html#dynamic-resource-allocation).
    +
    +The External Shuffle Service to use in the Mesos Shuffle Service. It provides shuffle data cleanup functionality
    +on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's
    +termination. To launch it, run `$SPARK_HOME/sbin/start-mesos-shuffle-service.sh` on all slave nodes with `spark.shuffle.service.enabled` set to true. This can be achieved through Marathon, using a unique host constraint.
    --- End diff --
    
    One thing to note, though. Marathon won't be able to launch `sbin/start-mesos-shuffle-service.sh` because it immediately goes to background and Marathon thinks it exited. It will keep re-launching to the end of days.
    
    What you need is to launch it via `spark-class`, for instance I'm using `bin/spark-class org.apache.spark.deploy.mesos.MesosExternalShuffleService`. See [this discussion](http://mail-archives.apache.org/mod_mbox/mesos-user/201511.mbox/%3C8623A103-25CA-4513-9D5B-D4AF96B98680@mesosphere.io%3E) on `mesos-user`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by mgummelt <gi...@git.apache.org>.
Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11047#discussion_r51761976
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -246,15 +246,15 @@ In either case, HDFS runs separately from Hadoop MapReduce, without being schedu
     
     # Dynamic Resource Allocation with Mesos
     
    -Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of executors based on statistics
    -of the application. While dynamic allocation supports both scaling up and scaling down the number of executors, the coarse grain scheduler only supports scaling down
    -since it is already designed to run one executor per slave with the configured amount of resources. However, after scaling down the number of executors the coarse grain scheduler
    -can scale back up to the same amount of executors when Spark signals more executors are needed.
    -
    -Users that like to utilize this feature should launch the Mesos Shuffle Service that
    -provides shuffle data cleanup functionality on top of the Shuffle Service since Mesos doesn't yet support notifying another framework's
    -termination. To launch/stop the Mesos Shuffle Service please use the provided sbin/start-mesos-shuffle-service.sh and sbin/stop-mesos-shuffle-service.sh
    -scripts accordingly.
    +Mesos supports dynamic allocation only with coarse grain mode, which can resize the number of
    --- End diff --
    
    I know it was this way before, but can you please s/coarse grain/coarse-grained.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179967323
  
    > but spark.dynamicAllocation.initialExecutors is not used at start-up.
    
    sorry what do you mean? Isn't that what this patch is fixing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/11047


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179409708
  
    @skyluc This change LGTM by the way. I'm just hesitant on backporting it into 1.6 since (1) it's a small issue, and (2) it changes core behavior and so affects other cluster modes as well. In general we try to be conservative about what goes into a maintenance release unless it's a critical issue.
    
    By the way I submitted the standalone mode equivalent of this patch at #11054. The solution is similar; the main difference is that in standalone mode the Master keeps track of the executor limit for each application, whereas in Mesos each driver keeps track of its own limit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180439396
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179418260
  
    For YARN, see `YarnSparkHadoopUtil.getInitialTargetExecutorNumber`. I don't think this change will cause any issues with the YARN backend (it should just see a request to set the target number of executors to the same number it already is, so it will just ignore it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179189444
  
    **[Test build #50657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50657/consoleFull)** for PR 11047 at commit [`1c75940`](https://github.com/apache/spark/commit/1c7594073267c8e0d4a58d7d4f6bd55df73d0316).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180390254
  
    **[Test build #50821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50821/consoleFull)** for PR 11047 at commit [`f5ab629`](https://github.com/apache/spark/commit/f5ab629fde5bd5520e367473160b708c7e23c535).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180428972
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180380428
  
    **[Test build #50820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50820/consoleFull)** for PR 11047 at commit [`003e865`](https://github.com/apache/spark/commit/003e8658e78d372ab24919a6ce02d7bb85c91b70).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-180439401
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50821/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13002][Mesos] Send initial request of e...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11047#issuecomment-179190004
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org