You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2009/11/26 02:33:39 UTC
[jira] Created: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Provide a description in the exception when an error is encountered parsing umask
---------------------------------------------------------------------------------
Key: HADOOP-6396
URL: https://issues.apache.org/jira/browse/HADOOP-6396
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.21.0, 0.22.0
Reporter: Jakob Homan
Assignee: Jakob Homan
Fix For: 0.21.0, 0.22.0
Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784217#action_12784217 ]
Hadoop QA commented on HADOOP-6396:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12426534/HADOOP-6396-B.patch
against trunk revision 885534.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/console
This message is automatically generated.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6396:
--------------------------------
Status: Patch Available (was: Open)
re-submitting patch.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6396:
--------------------------------
Status: Open (was: Patch Available)
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786280#action_12786280 ]
Hudson commented on HADOOP-6396:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #99 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/99/])
. Fix unhelpful exception message when unable to parse umask (jghoman)
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782756#action_12782756 ]
Hadoop QA commented on HADOOP-6396:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12426184/HADOOP-6396.patch
against trunk revision 883206.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/console
This message is automatically generated.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786372#action_12786372 ]
Hudson commented on HADOOP-6396:
--------------------------------
Integrated in Hadoop-Common-trunk #178 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/178/])
. Fix unhelpful exception message when unable to parse umask (jghoman)
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6396:
--------------------------------
Status: Patch Available (was: Open)
submitting patch.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6396:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this to trunk and 21. Closing issue.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785030#action_12785030 ]
Suresh Srinivas commented on HADOOP-6396:
-----------------------------------------
+1 the patch looks good.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6396:
--------------------------------
Attachment: HADOOP-6396.patch
Patch updates message and test case with more clear explanation of the issue. Tested against hdfs with new common jar and no problems.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6396) Provide a description in the
exception when an error is encountered parsing umask
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6396:
--------------------------------
Attachment: HADOOP-6396-B.patch
Had uploaded wrong version of patch, this is correct. Since test-patch's testing is suspect at the moment, ran unit tests locally and all passed. Verified solution in hdfs.
> Provide a description in the exception when an error is encountered parsing umask
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6396
> URL: https://issues.apache.org/jira/browse/HADOOP-6396
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6396-B.patch, HADOOP-6396.patch
>
>
> Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.