You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "viola.lu (JIRA)" <ji...@apache.org> on 2008/11/06 06:01:44 UTC
[jira] Created: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
------------------------------------------------------------------------------------------------------------------------------------
Key: GERONIMO-4395
URL: https://issues.apache.org/jira/browse/GERONIMO-4395
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: databases
Affects Versions: 2.1.3
Environment: Any platform
Reporter: viola.lu
Priority: Minor
Steps:
1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4395) EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
Posted by Ivan <xh...@gmail.com>.
True, I will open a JIRA to track it.Thanks, Lin !
2008/11/15 Lin Sun (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647653#action_12647653]
>
> Lin Sun commented on GERONIMO-4395:
> -----------------------------------
>
> BTW, I forgot to mention - I think a better approach is to allow users to
> config their own groupid (currently has to be console.db), version
> (currently has to be 1.0) and artifactId, from the portlet page. Ivan, if
> you like you are welcome to submit a patch for that.
>
> Thanks
>
> Lin
>
> > EmployeeDatasource and jdbc/EmployeeDatasource create the same files
> under $geronimo_install_dir/repository/console/dbpool directory
> >
> ------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: GERONIMO-4395
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> > Project: Geronimo
> > Issue Type: Bug
> > Security Level: public(Regular issues)
> > Components: databases
> > Affects Versions: 2.1.3
> > Environment: Any platform
> > Reporter: viola.lu
> > Assignee: Lin Sun
> > Priority: Minor
> > Attachments: Geronimo-4395-1109.patch,
> Geronimo-4395-1114-with-replace.patch,
> Geronimo-4395-1114-without-replace.patch, Geronimo-4395.patch
> >
> >
> > Steps:
> > 1.Login geronimo, go to database pool, create a "EmployeeDatasource"
> datasource with any db type.
> > 2.create another "jdbc/EmployeeDatasource" datasource with any db type.
> But some read error display that
> > EmployeeDatasource has existed in database pool.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Ivan
Re: [jira] Commented: (GERONIMO-4395) EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
Posted by Jack Cai <gr...@gmail.com>.
+1 for Option 2.
2008/11/7 Lin Sun (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645776#action_12645776]
>
> Lin Sun commented on GERONIMO-4395:
> -----------------------------------
>
> How about either options below -
>
> 1. Whenever user enters a non-unique database pool name, we warn the user
> immediately (for example, when they click on the Next button)
>
> 2. Only generate random artifactid when there the artifactid is not going
> to be unique since this is a very rare case. I like the preserve the
> current behavior because there is nothing wrong with it and I don't want to
> surprise our users to hunt for the artifact id.
>
> Thanks
>
> Lin
>
>
> > EmployeeDatasource and jdbc/EmployeeDatasource create the same files
> under $geronimo_install_dir/repository/console/dbpool directory
> >
> ------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: GERONIMO-4395
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> > Project: Geronimo
> > Issue Type: Bug
> > Security Level: public(Regular issues)
> > Components: databases
> > Affects Versions: 2.1.3
> > Environment: Any platform
> > Reporter: viola.lu
> > Priority: Minor
> > Attachments: Geronimo-4395.patch
> >
> >
> > Steps:
> > 1.Login geronimo, go to database pool, create a "EmployeeDatasource"
> datasource with any db type.
> > 2.create another "jdbc/EmployeeDatasource" datasource with any db type.
> But some read error display that
> > EmployeeDatasource has existed in database pool.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (GERONIMO-4395) EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
Posted by Ivan <xh...@gmail.com>.
Yes, a random artifact id may be less readable.But giving an error message
may make the uesr feel confusion, actually, the database pool name is OK, it
is different from any existing one, but the deployment failure is caused by
that an unique artifact id is needed.
I have another suggestion, after the user inputs the db pool name, and on
the second wizard page, show the user what the artifact id will be used. The
default artifact id would be replace all the slash in the dbpool name with
an underscore.
For example, if the db pool name is jdbc/TestDB, the default artifact id
would be jdbc_TestDB, we will check that whether the default artifact id has
been used, if it does, we generate a new artifact id, like jdbc_TestDB_1,
or we just use the default one, and show it on the page, so that the user
has the opportunity to change it.
Thanks for any comment !
2008/11/6 Lin Sun (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645486#action_12645486]
>
> Lin Sun commented on GERONIMO-4395:
> -----------------------------------
>
> I think I like the current impl better. Having a random datasource name
> generated can be a big usability issue as this name would be needed to be
> referred in the resource ref in geronimo plans.
>
> Also, I think this is a very rare case. Can you submit a patch to improve
> the error message?
>
> Lin
>
> > EmployeeDatasource and jdbc/EmployeeDatasource create the same files
> under $geronimo_install_dir/repository/console/dbpool directory
> >
> ------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: GERONIMO-4395
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> > Project: Geronimo
> > Issue Type: Bug
> > Security Level: public(Regular issues)
> > Components: databases
> > Affects Versions: 2.1.3
> > Environment: Any platform
> > Reporter: viola.lu
> > Priority: Minor
> > Attachments: Geronimo-4395.patch
> >
> >
> > Steps:
> > 1.Login geronimo, go to database pool, create a "EmployeeDatasource"
> datasource with any db type.
> > 2.create another "jdbc/EmployeeDatasource" datasource with any db type.
> But some read error display that
> > EmployeeDatasource has existed in database pool.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Ivan
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645486#action_12645486 ]
Lin Sun commented on GERONIMO-4395:
-----------------------------------
I think I like the current impl better. Having a random datasource name generated can be a big usability issue as this name would be needed to be referred in the resource ref in geronimo plans.
Also, I think this is a very rare case. Can you submit a patch to improve the error message?
Lin
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645712#action_12645712 ]
Jack Cai commented on GERONIMO-4395:
------------------------------------
OK, so this is really the artifact ID instead of the datasource name. The new proposal here looks good to me.
2008/11/7 Ivan <xh...@gmail.com>
Yes, a random artifact id may be less readable.
But giving an error message may make the uesr feel confusion, actually, the database pool name is OK, it is different from any existing one, but the deployment failure is caused by that an unique artifact id is needed.
I have another suggestion, after the user inputs the db pool name, and on the second wizard page, show the user what the artifact id will be used. The default artifact id would be replace all the slash in the dbpool name with an underscore.
For example, if the db pool name is jdbc/TestDB, the default artifact id would be jdbc_TestDB, we will check that whether the default artifact id has been used, if it does, we generate a new artifact id, like jdbc_TestDB_1, or we just use the default one, and show it on the page, so that the user has the opportunity to change it.
Thanks for any comment !
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lin Sun closed GERONIMO-4395.
-----------------------------
Close issue. Tested with many scenarios and the itest.
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395-1114-with-replace.patch, Geronimo-4395-1114-without-replace.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan updated GERONIMO-4395:
---------------------------
Attachment: Geronimo-4395-1114-with-replace.patch
Geronimo-4395-1114-without-replace.patch
I create two patch, one is with the replacement code, another is not.
I added some extra codes to handle if the pool name is end with '/'.
I have run the console test suites, the patch does not cause any case fails.
By the way, I guess we need to put more validation logic on the client side, not in the port lets, so that we could avoid too many codes in the port let to handle all the user inputs.
Please help to review the patch, Thanks !
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395-1114-with-replace.patch, Geronimo-4395-1114-without-replace.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lin Sun reassigned GERONIMO-4395:
---------------------------------
Assignee: Lin Sun
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647469#action_12647469 ]
David Jencks commented on GERONIMO-4395:
----------------------------------------
I like replacing / with _.
I haven't looked at the patch so I don't know what "random string" means. If it means appending _1, _2, .... until an unused artifactId is obtained, I've fine with it.
I hope there's a way for the user to specify the groupId and artifactId..... haven't looked at this portlet page recently.
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan updated GERONIMO-4395:
---------------------------
Attachment: Geronimo-4395-1109.patch
Another patch based the discussion is created.
It keeps the artifactid convenstion as before, two modifcation has made
a. Replace all the '/' in the db pool name.
b. If the artifactid has already exists in the configuration store, a random string is added to the artifact.
Please help to review it, and thanks for any comment !
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647405#action_12647405 ]
Lin Sun commented on GERONIMO-4395:
-----------------------------------
Ivan, can you please generate patch from the root dir (for easily apply)? I'd suggest removing the string replacement line.
Also, can you please make sure the patch won't break any unit test or add some unit test as appropriate?
Lin
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647300#action_12647300 ]
Lin Sun commented on GERONIMO-4395:
-----------------------------------
Patch looks good to me. The other thing is that I was not planning to do the string replacement so that we keep the old behavior. I'll try integrate it.
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lin Sun resolved GERONIMO-4395.
-------------------------------
Resolution: Fixed
Patch with slight modification committed to trunk and branch 2.1 (see revisions under subversion tab). Took Ivan and David's suggestion and simply replace / with _. Many thanks Ivan for the patches and David for the input!
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395-1114-with-replace.patch, Geronimo-4395-1114-without-replace.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645424#action_12645424 ]
Jack Cai commented on GERONIMO-4395:
------------------------------------
I guess this is just a convention. Ivan's solution might not be good when commands are used to create the datasource and the user expects the name unchanged. I'd say the current design is OK, as long as we can improve the error message.
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645779#action_12645779 ]
Lin Sun commented on GERONIMO-4395:
-----------------------------------
*ignore my previous comment * hit send too quickly:
How about -
Only generate random artifactid when there the artifactid is not going to be unique since this is a very rare case. I like the preserve the current behavior because there is nothing wrong with it and I don't want to surprise our users of the change and hunt for the artifact id.
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan updated GERONIMO-4395:
---------------------------
Attachment: Geronimo-4395.patch
For the '/' should not exist in the artifact id, or it will fail to deploy the db pool
The orginal implementation is :
artifactId = artifactId.substring(artifactId.indexOf('/') + 1);
But with this solution, it could not handle the name with more than two slash, and for "jdbc/TestDBPool" and "TestDBPool" will generate the same artifact id "TestDBPool"
In the patch, a random string is appended to the artifact, although it will make the artifact id less readable, the end user could paste it from the "usuage" portlet. So it may not be a big issue.
Thanks for any comment !
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647494#action_12647494 ]
Ivan commented on GERONIMO-4395:
--------------------------------
Thanks for the comments Lin and David.
I will recreate the patch from the root dir.
a. The reason that I replace the / is for '/' will cause the deployment failed.
b. About the random string, for in the current implementation, the codes will check whether there is a '/' in the pool name, if it does, the substring of the pool name is used as the artifact id. Let's take an example, "testpool" and "jdbc/testpool" will get the same artifact id "testpool", I will append a random string if the "testpool" exists already.
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647653#action_12647653 ]
Lin Sun commented on GERONIMO-4395:
-----------------------------------
BTW, I forgot to mention - I think a better approach is to allow users to config their own groupid (currently has to be console.db), version (currently has to be 1.0) and artifactId, from the portlet page. Ivan, if you like you are welcome to submit a patch for that.
Thanks
Lin
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Assignee: Lin Sun
> Priority: Minor
> Attachments: Geronimo-4395-1109.patch, Geronimo-4395-1114-with-replace.patch, Geronimo-4395-1114-without-replace.patch, Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4395) EmployeeDatasource and
jdbc/EmployeeDatasource create the same files under
$geronimo_install_dir/repository/console/dbpool directory
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645776#action_12645776 ]
Lin Sun commented on GERONIMO-4395:
-----------------------------------
How about either options below -
1. Whenever user enters a non-unique database pool name, we warn the user immediately (for example, when they click on the Next button)
2. Only generate random artifactid when there the artifactid is not going to be unique since this is a very rare case. I like the preserve the current behavior because there is nothing wrong with it and I don't want to surprise our users to hunt for the artifact id.
Thanks
Lin
> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4395
> URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: databases
> Affects Versions: 2.1.3
> Environment: Any platform
> Reporter: viola.lu
> Priority: Minor
> Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.