You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/06 17:55:56 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #12946: KAFKA-14427 ZK client support for migrations

cmccabe commented on code in PR #12946:
URL: https://github.com/apache/kafka/pull/12946#discussion_r1041287139


##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -54,6 +54,19 @@ import org.apache.kafka.common.utils.Sanitizer
 import scala.collection.{Map, mutable, _}
 import scala.jdk.CollectionConverters._
 
+object ZkAdminManager {
+  def clientQuotaPropsToDoubleMap(props: Map[String, String]): Map[String, Double] = {

Review Comment:
   can we have a unit test for this function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org