[jira] Commented: (AVRO-26) Converting JUnit tests into TestNG controlled environment

["Doug Cutting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705704#action_12705704 ] 

Doug Cutting commented on AVRO-26:
----------------------------------

Overall this looks good.  A few comments:
 - 'generated' is not a good name for this.  let's instead name it something like "hello", "simple" or "testProtocol".
 - if testng is in lib/, then we don't need testng.classpath but can just use the normal classpath.  we could instead put it in src/test/lib or somesuch.  if we do that, build.xml should not contain the full version-laden file name, but rather a version-free directory, so that we can change testng versions without editing build.xml.
 - we should continue to support something like 'ant test-java -Dtestcase=TestFoo', to permit folks to run just a single test.
 - i would not update the ant task descriptions to say "with TestNG"
 - do we need the taskdef in more than one place in build.xml?
 - the "reports" task should probably be named "test-java-reports" or "test-reports".
 - i must be the only person in the world who likes to use asterisks in imports...



> Converting JUnit tests into TestNG controlled environment
> ---------------------------------------------------------
>
>                 Key: AVRO-26
>                 URL: https://issues.apache.org/jira/browse/AVRO-26
>             Project: Avro
>          Issue Type: Test
>          Components: java, python
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: AVRO-26.patch.1
>
>
> TestNG is a powerful test harness, which provides a lot of useful features like parallel test execution, test parametrization, and such.
> Avro uses JUnit environment instead which is more rigid and less efficient.
> I'd suggest to convert Avro's Junit based test infrastructure into TestNG controller environment, which will allow to achieve higher level of test execution control in the long run

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.