You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/06/30 21:14:54 UTC
[GitHub] cordova-lib pull request: CB-7056 serve: return promise of server
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-lib/pull/48
CB-7056 serve: return promise of server
+ restore serve tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-lib cb_7056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 883720146a484f65ba35061a6f25e4a232df0b76
Author: Josh Soref <js...@blackberry.com>
Date: 2014-06-30T13:50:47Z
CB-7056 serve: return promise of server
+ restore serve tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7056 serve: return promise of server
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7056 serve: return promise of server
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/48#issuecomment-47789192
This breaks the specs. @jsoref could you please take a look at this.
The errors are different depending on whether you run "npm test" or "jasmine-node spec-cordova/serve.spec.js". And the errors are different on OSX and Linux. Might be some problem with chdirs and temp folders.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7056 serve: return promise of server
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/48#issuecomment-47797251
I have an update, I'll post it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---