You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/06/10 12:22:29 UTC

Review Request 35290: Tell Ambari the value of topology.max.replication.wait.time.sec for Storm HA. Additional fixes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35290/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Sriharsha Chintalapani, and Vitalyi Brodetskyi.


Bugs: AMBARI-11435
    https://issues.apache.org/jira/browse/AMBARI-11435


Repository: ambari


Description
-------

Fixing None default value for already committed AMBARI-11435 patch.


Diffs
-----

  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py d0ed8f0 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py 688b1d9 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml c7309e5 
  ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml 4656a45 

Diff: https://reviews.apache.org/r/35290/diff/


Testing
-------

Checked deploying a new cluster

----------------------------------------------------------------------
Ran 266 tests in 6.226s

OK
----------------------------------------------------------------------
Total run:785
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko

Re: Review Request 35290: Tell Ambari the value of topology.max.replication.wait.time.sec for Storm HA. Additional fixes

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35290/#review87429
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On June 10, 2015, 6:22 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35290/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 6:22 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sriharsha Chintalapani, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11435
>     https://issues.apache.org/jira/browse/AMBARI-11435
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixing None default value for already committed AMBARI-11435 patch.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py d0ed8f0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py 688b1d9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml c7309e5 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml 4656a45 
> 
> Diff: https://reviews.apache.org/r/35290/diff/
> 
> 
> Testing
> -------
> 
> Checked deploying a new cluster
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 6.226s
> 
> OK
> ----------------------------------------------------------------------
> Total run:785
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 35290: Tell Ambari the value of topology.max.replication.wait.time.sec for Storm HA. Additional fixes

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On June 10, 2015, 5:48 p.m., Parth Brahmbhatt wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py, line 96
> > <https://reviews.apache.org/r/35290/diff/1/?file=981982#file981982line96>
> >
> >     In case of HA this should be set to > 1. Ideally it should be floor(n/2 +1).

Thanks for pointing this out. Original patch is already committed as it was QE blocker. I'll include this tweak in a separate patch.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35290/#review87430
-----------------------------------------------------------


On June 10, 2015, 10:22 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35290/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 10:22 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sriharsha Chintalapani, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11435
>     https://issues.apache.org/jira/browse/AMBARI-11435
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixing None default value for already committed AMBARI-11435 patch.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py d0ed8f0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py 688b1d9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml c7309e5 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml 4656a45 
> 
> Diff: https://reviews.apache.org/r/35290/diff/
> 
> 
> Testing
> -------
> 
> Checked deploying a new cluster
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 6.226s
> 
> OK
> ----------------------------------------------------------------------
> Total run:785
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 35290: Tell Ambari the value of topology.max.replication.wait.time.sec for Storm HA. Additional fixes

Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35290/#review87430
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
<https://reviews.apache.org/r/35290/#comment139746>

    In case of HA this should be set to > 1. Ideally it should be floor(n/2 +1).


- Parth Brahmbhatt


On June 10, 2015, 10:22 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35290/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 10:22 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sriharsha Chintalapani, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11435
>     https://issues.apache.org/jira/browse/AMBARI-11435
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixing None default value for already committed AMBARI-11435 patch.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py d0ed8f0 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py 688b1d9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml c7309e5 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml 4656a45 
> 
> Diff: https://reviews.apache.org/r/35290/diff/
> 
> 
> Testing
> -------
> 
> Checked deploying a new cluster
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 6.226s
> 
> OK
> ----------------------------------------------------------------------
> Total run:785
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>