You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/19 22:33:21 UTC
[GitHub] [incubator-pekko-management] mdedetrich opened a new pull request, #70: Fix typo in Pekko org
mdedetrich opened a new pull request, #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70
Accidental typo from https://github.com/apache/incubator-pekko-management/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on pull request #70: Use correct org.apache.pekko group id in docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#issuecomment-1555855995
> I don't see any update in the project/Common.scala for organization project setting, I think that's needed too.
That is being set with [sbt-apache-sonatype](https://github.com/mdedetrich/sbt-apache-sonatype). It sets the org based on https://github.com/apache/incubator-pekko-management/blob/b5c0aca9a7275bfb51fb47e878bc886ebc37c25d/build.sbt#L4
```
[IJ]show organization
[info] discovery-consul / organization
[info] org.apache.pekko
[info] discovery-kubernetes-api / organization
[info] org.apache.pekko
[info] integration-test-aws-api-ecs / organization
[info] org.apache.pekko
[info] management-cluster-bootstrap / organization
[info] org.apache.pekko
[info] discovery-aws-api-async / organization
[info] org.apache.pekko
[info] integration-test-kubernetes-dns / organization
[info] org.apache.pekko
[info] integration-test-marathon-api-docker / organization
[info] org.apache.pekko
[info] management / organization
[info] org.apache.pekko
[info] discovery-aws-api / organization
[info] org.apache.pekko
[info] lease-kubernetes-int-test / organization
[info] org.apache.pekko
[info] integration-test-aws-api-ec2 / organization
[info] org.apache.pekko
[info] integration-test-local / organization
[info] org.apache.pekko
[info] management-cluster-http / organization
[info] org.apache.pekko
[info] lease-kubernetes / organization
[info] org.apache.pekko
[info] docs / organization
[info] org.apache.pekko
[info] management-loglevels-log4j2 / organization
[info] org.apache.pekko
[info] integration-test-kubernetes-api / organization
[info] org.apache.pekko
[info] discovery-marathon-api / organization
[info] org.apache.pekko
[info] management-loglevels-logback / organization
[info] org.apache.pekko
[info] integration-test-kubernetes-api-java / organization
[info] org.apache.pekko
[info] management-pki / organization
[info] org.apache.pekko
[info] organization
[info] org.apache.pekko
[IJ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #70: Fix typo in Pekko org
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#discussion_r1199492059
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -52,7 +52,7 @@ This is a separate JAR file:
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="org.apache.pekko.pekko.discovery"
+ group="org.apache.pekko.discovery"
Review Comment:
we don't currently have any jars in this groupId - we use `org.apache.pekko` for every jar - see https://repository.apache.org/content/groups/snapshots/org/apache/pekko/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #70: Use correct org.apache.pekko group id in docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#discussion_r1199576606
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -166,7 +166,7 @@ preview SDK. The disadvantage is that the mainstream SDK does blocking IO.
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="org.apache.pekko.pekko.discovery"
+ group="org.apache.pekko.discovery"
Review Comment:
Thanks, there was indeed a few more cases of this in the docs. Just fixed and force pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich merged pull request #70: Use correct org.apache.pekko group id in docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] He-Pin commented on a diff in pull request #70: Use correct org.apache.pekko group id in docs
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#discussion_r1199576237
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -166,7 +166,7 @@ preview SDK. The disadvantage is that the mainstream SDK does blocking IO.
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="org.apache.pekko.pekko.discovery"
+ group="org.apache.pekko.discovery"
Review Comment:
not `group="org.apache.pekko"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] He-Pin commented on pull request #70: Use correct org.apache.pekko group id in docs
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#issuecomment-1555860908
Thanks @mdedetrich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #70: Fix typo in Pekko org
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#discussion_r1199493683
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -52,7 +52,7 @@ This is a separate JAR file:
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="org.apache.pekko.pekko.discovery"
+ group="org.apache.pekko.discovery"
Review Comment:
I see, til. Fixed and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] He-Pin commented on pull request #70: Use correct org.apache.pekko group id in docs
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #70:
URL: https://github.com/apache/incubator-pekko-management/pull/70#issuecomment-1555848392
I don't see any update in the `project/Common.scala` for `organization` project setting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org