You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/14 09:56:54 UTC
[GitHub] tillrohrmann commented on a change in pull request #7257:
[FLINK-11089]Log filecache directory removed messages
tillrohrmann commented on a change in pull request #7257: [FLINK-11089]Log filecache directory removed messages
URL: https://github.com/apache/flink/pull/7257#discussion_r256761210
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
##########
@@ -150,9 +150,10 @@ public void shutdown() {
for (File dir : storageDirectories) {
try {
FileUtils.deleteDirectory(dir);
+ LOG.info("removed file cache directory {}", dir.getAbsolutePath());
}
catch (IOException e) {
- LOG.error("File cache could not properly clean up storage directory.");
+ LOG.error("File cache could not properly clean up storage directory: {}", dir, e);
Review comment:
I would suggest to make the directory information symmetric: Either `dir.getAbsolutePath()` or `dir` in both logging statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services