You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/22 21:19:50 UTC

[GitHub] [fineract] vorburger commented on pull request #1186: FINERACT-1052 global config for Loan OverPayment

vorburger commented on pull request #1186:
URL: https://github.com/apache/fineract/pull/1186#issuecomment-662702555


   > if over_payment is disabled, then this test should be skipped please advise
   
   @francisguchie it's your responsibility to make this PR pass the build.
   
   I don't understand enough about the functionality here, but are we changing the default here? Should the SQL script insert TRUE instead of FALSE to preserve current behaviour, so that this becomes an explicit "opt-in"? Alternatively, should (will YOU) change the test, as part of this PR?
   
   @ptuomola don't know if you have any interest to engage on this one, some time (no rush).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org