You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2019/02/26 22:05:42 UTC
[arrow] branch master updated: ARROW-4686: [Dev] Only accept 'y' or
'n' in merge_arrow_pr.py prompts
This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 28e28b8 ARROW-4686: [Dev] Only accept 'y' or 'n' in merge_arrow_pr.py prompts
28e28b8 is described below
commit 28e28b820b441683f414b46d22622b730b99fda2
Author: Brian Hulette <hu...@gmail.com>
AuthorDate: Tue Feb 26 23:05:34 2019 +0100
ARROW-4686: [Dev] Only accept 'y' or 'n' in merge_arrow_pr.py prompts
Author: Brian Hulette <hu...@gmail.com>
Closes #3761 from TheNeuralBit/y-n-only and squashes the following commits:
7c7c1e958 <Brian Hulette> Only accept 'y' or 'n' in merge_arrow_pr.py prompts, retry until one is received.
---
dev/merge_arrow_pr.py | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/dev/merge_arrow_pr.py b/dev/merge_arrow_pr.py
index 6c7e853..9332d49 100755
--- a/dev/merge_arrow_pr.py
+++ b/dev/merge_arrow_pr.py
@@ -228,9 +228,14 @@ class CommandInput(object):
return getpass.getpass(prompt)
def continue_maybe(self, prompt):
- result = input("\n%s (y/n): " % prompt)
- if result.lower() != "y":
- self.fail("Okay, exiting")
+ while True:
+ result = input("\n%s (y/n): " % prompt)
+ if result.lower() == "y":
+ return
+ elif result.lower() == "n":
+ self.fail("Okay, exiting")
+ else:
+ prompt = "Please input 'y' or 'n'"
class PullRequest(object):