You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/10 00:10:19 UTC
[GitHub] sijie commented on a change in pull request #3249: [client] Issue
3218: Support specifying multiple hosts in pulsar service url and web url
sijie commented on a change in pull request #3249: [client] Issue 3218: Support specifying multiple hosts in pulsar service url and web url
URL: https://github.com/apache/pulsar/pull/3249#discussion_r246597126
##########
File path: pulsar-common/src/test/java/org/apache/pulsar/common/net/ServiceURITest.java
##########
@@ -0,0 +1,233 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.net;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.fail;
+import static org.testng.internal.junit.ArrayAsserts.assertArrayEquals;
+
+import java.net.URI;
+import org.testng.annotations.Test;
+
+/**
+ * Unit test {@link ServiceURI}.
+ */
+public class ServiceURITest {
+
+ private static void assertServiceUri(
+ String serviceUri,
+ String expectedServiceName,
+ String[] expectedServiceInfo,
+ String expectedServiceUser,
+ String[] expectedServiceHosts,
+ String expectedServicePath) {
+
+ ServiceURI serviceURI = ServiceURI.create(serviceUri);
+
+ assertEquals(expectedServiceName, serviceURI.getServiceName());
+ assertArrayEquals(expectedServiceInfo, serviceURI.getServiceInfos());
+ assertEquals(expectedServiceUser, serviceURI.getServiceUser());
+ assertArrayEquals(expectedServiceHosts, serviceURI.getServiceHosts());
+ assertEquals(expectedServicePath, serviceURI.getServicePath());
+ }
+
+ @Test
+ public void testInvalidServiceUris() {
+ String[] uris = new String[] {
+ "://localhost:6650", // missing scheme
+ "pulsar:///", // missing authority
+ "pulsar://localhost:6650:6651/", // invalid hostname pair
+ "pulsar://localhost:xyz/", // invalid port
+ "pulsar://localhost:-6650/", // negative port
+ };
+
+ for (String uri : uris) {
+ testInvalidServiceUri(uri);
+ }
+ }
+
+ @Test(expectedExceptions = NullPointerException.class)
+ public void testNullServiceUriString() {
+ ServiceURI.create((String) null);
+ }
+
+ @Test(expectedExceptions = NullPointerException.class)
+ public void testNullServiceUriInstance() {
+ ServiceURI.create((URI) null);
+ }
+
+ @Test(expectedExceptions = IllegalArgumentException.class)
+ public void testEmptyServiceUriString() {
+ ServiceURI.create("");
+ }
+
+ private void testInvalidServiceUri(String serviceUri) {
+ try {
+ ServiceURI.create(serviceUri);
+ fail("Should fail to parse service uri : " + serviceUri);
+ } catch (IllegalArgumentException iae) {
+ // expected
+ }
+ }
+
+ @Test
+ public void testMissingServiceName() {
+ String serviceUri = "//localhost:6650/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ null, new String[0], null, new String[] { "localhost:6650" }, "/path/to/namespace");
+ }
+
+ @Test
+ public void testEmptyPath() {
+ String serviceUri = "pulsar://localhost:6650";
+ assertServiceUri(
+ serviceUri,
+ "pulsar", new String[0], null, new String[] { "localhost:6650" }, "");
+ }
+
+ @Test
+ public void testRootPath() {
+ String serviceUri = "pulsar://localhost:6650/";
+ assertServiceUri(
+ serviceUri,
+ "pulsar", new String[0], null, new String[] { "localhost:6650" }, "/");
+ }
+
+ @Test
+ public void testUserInfo() {
+ String serviceUri = "pulsar://pulsaruser@localhost:6650/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[0],
+ "pulsaruser",
+ new String[] { "localhost:6650" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsSemiColon() {
+ String serviceUri = "pulsar://host1:6650;host2:6650;host3:6650/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[0],
+ null,
+ new String[] { "host1:6650", "host2:6650", "host3:6650" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsComma() {
+ String serviceUri = "pulsar://host1:6650,host2:6650,host3:6650/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[0],
+ null,
+ new String[] { "host1:6650", "host2:6650", "host3:6650" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsWithoutPulsarPorts() {
+ String serviceUri = "pulsar://host1,host2,host3/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[0],
+ null,
+ new String[] { "host1:6650", "host2:6650", "host3:6650" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsWithoutPulsarTlsPorts() {
+ String serviceUri = "pulsar+ssl://host1,host2,host3/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[] { "ssl" },
+ null,
+ new String[] { "host1:6651", "host2:6651", "host3:6651" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsWithoutHttpPorts() {
+ String serviceUri = "http://host1,host2,host3/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "http",
+ new String[0],
+ null,
+ new String[] { "host1:8080", "host2:8080", "host3:8080" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsWithoutHttpsPorts() {
+ String serviceUri = "https://host1,host2,host3/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "https",
+ new String[0],
+ null,
+ new String[] { "host1:8443", "host2:8443", "host3:8443" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsMixedPorts() {
+ String serviceUri = "pulsar://host1:6640,host2:6650,host3:6660/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[0],
+ null,
+ new String[] { "host1:6640", "host2:6650", "host3:6660" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testMultipleHostsMixed() {
+ String serviceUri = "pulsar://host1:6640,host2,host3:6660/path/to/namespace";
+ assertServiceUri(
+ serviceUri,
+ "pulsar",
+ new String[0],
+ null,
+ new String[] { "host1:6640", "host2:6650", "host3:6660" },
+ "/path/to/namespace");
+ }
+
+ @Test
+ public void testUserInfoWithMultipleHosts() {
+ String serviceUri = "pulsar://pulsaruser@host1:6650;host2:6650;host3:6650/path/to/namespace";
Review comment:
The ServiceURI is borrowed from bookkeeper. It is a generic class, so the test here is only to test the functionalities of this class itself. How pulsar will use the components is up to pulsar logic. So there is no "issue" / "features" for that, unless there are someone is asking for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services