[GitHub] [beam] KevinGG commented on a change in pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

[GitBox <gi...@apache.org>]

KevinGG commented on a change in pull request #16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r788135638



##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -220,6 +220,24 @@ def display_timezone(self, value):
     """
     self._display_timezone = value
 
+  @property
+  def specified_cache_dir(self):
+    """The cache directory specified by the user.
+
+    Defaults to None.
+    """
+    return self._specified_cache_dir
+
+  @specified_cache_dir.setter
+  def specified_cache_dir(self, value):
+    """Sets the cache directory.
+
+    Defaults to None.
+
+    Example::
+      interactive_beam.options.specified_cache_dir = "gs://"

Review comment:
       Can we add examples for local disk too?
   
   - /Users/username/my/cache/dir
   
   Also, it might improve the readability to make the GCS path example "gs://my-gcs-bucket/cache/dir".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org