You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/07 09:29:02 UTC

[GitHub] [cordova] janpio opened a new issue #103: [Plugins] Typings

janpio opened a new issue #103: [Plugins] Typings
URL: https://github.com/apache/cordova/issues/103
 
 
   Most of our plugins now have a `types` folder where we have typing for Typescript:
   
   https://github.com/apache/cordova-plugin-statusbar/tree/master/types
   https://github.com/apache/cordova-plugin-statusbar/blob/master/types/index.d.ts
   
   This is useful, especially in the context of Ionic and Angular. @timbru31 is our typings expert, and takes on the role of keeping those up to date and is their "owner" more or less.
   
   I have some questions:
   
   - In https://github.com/apache/cordova-plugin-statusbar/pull/132 the question came up of including the plugin version number in the typings themselves. Do we actually need to do that, when we host the typings ourselves? Updating those version numbers would add an extra step to the release process (and surely be forgotten from time to time). So if they are not _needed_ for our self hosted typings, I would rather leave them out.
   
   Also:
   
   - Are there tools to create these typings automatically?
   - Are there tools to check if the typings are current and valid somehow?
   
   We need some documentation that is more than "ask @timbru31" so that we can properly support those typings as part of our core plugins, and maybe even give guidance to plugin authors why and how to include them in theirs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org