You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Billie Rinaldi <bi...@apache.org> on 2014/10/23 22:15:21 UTC
Review Request 27106: ACCUMULO-898 convert to htrace
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/
-----------------------------------------------------------
Review request for accumulo and Eric Newton.
Repository: accumulo
Description
-------
Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
Diffs
-----
assemble/bin/stop-all.sh 4bf06c0
assemble/pom.xml 89a3747
assemble/src/main/assemblies/component.xml 599d26c
core/pom.xml 10e7d71
core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
core/src/main/scripts/generate-thrift.sh 9fe743d
docs/src/main/asciidoc/chapters/administration.txt d5e73f0
docs/src/main/resources/distributedTracing.html 54c9095
examples/simple/pom.xml 37adc00
examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
pom.xml ebc2f2f
server/base/pom.xml 60762be
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
server/gc/pom.xml 8194121
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
server/master/pom.xml 3b9684c
server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
server/monitor/pom.xml a847183
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
server/tracer/pom.xml e1f61e6
server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
server/tserver/pom.xml 65c33ec
server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
shell/pom.xml a5af4b8
shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
test/pom.xml 78909e1
test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
trace/pom.xml aacfb56
trace/src/main/findbugs/exclude-filter.xml 408a32c
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
trace/src/main/scripts/generate-thrift.sh b8a46b6
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
Diff: https://reviews.apache.org/r/27106/diff/
Testing
-------
File Attachments
----------------
deleted files
https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
package / import changes
https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
thrift generated code
https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
Thanks,
Billie Rinaldi
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review58087
-----------------------------------------------------------
docs/src/main/asciidoc/chapters/administration.txt
<https://reviews.apache.org/r/27106/#comment98978>
Needs information about how to configure span receivers.
- Billie Rinaldi
On Oct. 23, 2014, 8:16 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:16 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> core/src/main/scripts/generate-thrift.sh 9fe743d
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/pom.xml 37adc00
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/pom.xml 60762be
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/pom.xml 8194121
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
> server/master/pom.xml 3b9684c
> server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/pom.xml a847183
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/pom.xml e1f61e6
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
> server/tserver/pom.xml 65c33ec
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
> shell/pom.xml a5af4b8
> shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/pom.xml 78909e1
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
> test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
> trace/pom.xml aacfb56
> trace/src/main/findbugs/exclude-filter.xml 408a32c
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/scripts/generate-thrift.sh b8a46b6
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> deleted files
> https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
> package / import changes
> https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
> thrift generated code
> https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review58085
-----------------------------------------------------------
File Attachment: package / import changes - ACCUMULO-898-3-package-import-only.patch
<https://reviews.apache.org//r/27106/#fcomment34>
TraceRepoDeserializationTest fails.
- Billie Rinaldi
On Oct. 23, 2014, 8:16 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:16 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> core/src/main/scripts/generate-thrift.sh 9fe743d
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/pom.xml 37adc00
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/pom.xml 60762be
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/pom.xml 8194121
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
> server/master/pom.xml 3b9684c
> server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/pom.xml a847183
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/pom.xml e1f61e6
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
> server/tserver/pom.xml 65c33ec
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
> shell/pom.xml a5af4b8
> shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/pom.xml 78909e1
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
> test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
> trace/pom.xml aacfb56
> trace/src/main/findbugs/exclude-filter.xml 408a32c
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/scripts/generate-thrift.sh b8a46b6
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> deleted files
> https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
> package / import changes
> https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
> thrift generated code
> https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review59769
-----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/trace/Span.java
<https://reviews.apache.org/r/27106/#comment101077>
This should return a Span.
trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java
<https://reviews.apache.org/r/27106/#comment101078>
It would be better to preserve and rename the interface to ensure the methods are preserved.
- Billie Rinaldi
On Oct. 23, 2014, 8:16 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:16 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> core/src/main/scripts/generate-thrift.sh 9fe743d
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/pom.xml 37adc00
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/pom.xml 60762be
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/pom.xml 8194121
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
> server/master/pom.xml 3b9684c
> server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/pom.xml a847183
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/pom.xml e1f61e6
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
> server/tserver/pom.xml 65c33ec
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
> shell/pom.xml a5af4b8
> shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/pom.xml 78909e1
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
> test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
> trace/pom.xml aacfb56
> trace/src/main/findbugs/exclude-filter.xml 408a32c
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/scripts/generate-thrift.sh b8a46b6
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> deleted files
> https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
> package / import changes
> https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
> thrift generated code
> https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review60332
-----------------------------------------------------------
Ship it!
Some whitespace on empty lines issues that would be nice to get resolved (but not blocker). Thanks for the work Jim and Billie.
- Josh Elser
On Nov. 6, 2014, 11:20 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 11:20 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-5.patch. This patch could stand alone. The file attached does a lot of additional refactoring, removing or deprecating everything in the trace module. So we can decide whether to apply just the first patch or both.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java a558760
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/AsyncSpanReceiver.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/SendSpansViaThrift.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 9586eaa
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 5c93a53
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 45e883d
> server/base/src/main/java/org/apache/accumulo/server/trace/TraceFSDataInputStream.java 5162e01
> server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java d3fbad7
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 6c7fd47
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java f943ac1
> server/master/src/main/java/org/apache/accumulo/master/Master.java e3fc69d
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 49bb56d
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 4858b8a
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java f7bda49
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 54c75f8
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java ef3a0c9
> shell/src/main/java/org/apache/accumulo/shell/Shell.java a0ff17a
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 7f6c514
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 4d9d479
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 80ee990
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java 03677f4
> trace/pom.xml aacfb56
> trace/src/main/java/org/apache/accumulo/trace/instrument/CloudtraceSpan.java PRE-CREATION
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceProxy.java cb93210
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/Tracer.java d70aeea
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/MilliSpan.java b641a2c
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/NullSpan.java 916b6cf
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/RootMilliSpan.java c25e644
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/LogSpans.java dfed660
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/ZooSpanClient.java 84e3204
> trace/src/main/java/org/apache/accumulo/trace/thrift/Annotation.java PRE-CREATION
> trace/src/main/java/org/apache/accumulo/trace/thrift/RemoteSpan.java 416ae17
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ACCUMULO-898-5-additional-refactoring.patch
> https://reviews.apache.org/media/uploaded/files/2014/11/06/ba7f147e-3918-4376-92ec-6feeb82ef31a__ACCUMULO-898-5-additional-refactoring.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Eric Newton <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review60318
-----------------------------------------------------------
Ship it!
- Eric Newton
On Nov. 6, 2014, 11:20 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 11:20 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-5.patch. This patch could stand alone. The file attached does a lot of additional refactoring, removing or deprecating everything in the trace module. So we can decide whether to apply just the first patch or both.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java a558760
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/AsyncSpanReceiver.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/SendSpansViaThrift.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 9586eaa
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 5c93a53
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 45e883d
> server/base/src/main/java/org/apache/accumulo/server/trace/TraceFSDataInputStream.java 5162e01
> server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java d3fbad7
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 6c7fd47
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java f943ac1
> server/master/src/main/java/org/apache/accumulo/master/Master.java e3fc69d
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 49bb56d
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 4858b8a
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java f7bda49
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 54c75f8
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java ef3a0c9
> shell/src/main/java/org/apache/accumulo/shell/Shell.java a0ff17a
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 7f6c514
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 4d9d479
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 80ee990
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java 03677f4
> trace/pom.xml aacfb56
> trace/src/main/java/org/apache/accumulo/trace/instrument/CloudtraceSpan.java PRE-CREATION
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceProxy.java cb93210
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/Tracer.java d70aeea
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/MilliSpan.java b641a2c
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/NullSpan.java 916b6cf
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/RootMilliSpan.java c25e644
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/LogSpans.java dfed660
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/ZooSpanClient.java 84e3204
> trace/src/main/java/org/apache/accumulo/trace/thrift/Annotation.java PRE-CREATION
> trace/src/main/java/org/apache/accumulo/trace/thrift/RemoteSpan.java 416ae17
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ACCUMULO-898-5-additional-refactoring.patch
> https://reviews.apache.org/media/uploaded/files/2014/11/06/ba7f147e-3918-4376-92ec-6feeb82ef31a__ACCUMULO-898-5-additional-refactoring.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 11:20 p.m.)
Review request for accumulo and Eric Newton.
Repository: accumulo
Description (updated)
-------
Main diff is ACCUMULO-898-5.patch. This patch could stand alone. The file attached does a lot of additional refactoring, removing or deprecating everything in the trace module. So we can decide whether to apply just the first patch or both.
Diffs (updated)
-----
assemble/bin/stop-all.sh 4bf06c0
assemble/pom.xml 89a3747
assemble/src/main/assemblies/component.xml 599d26c
core/pom.xml 10e7d71
core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
core/src/main/java/org/apache/accumulo/core/conf/Property.java a558760
core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
core/src/main/java/org/apache/accumulo/core/trace/AsyncSpanReceiver.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
core/src/main/java/org/apache/accumulo/core/trace/SendSpansViaThrift.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 9586eaa
core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
docs/src/main/asciidoc/chapters/administration.txt d5e73f0
docs/src/main/resources/distributedTracing.html 54c9095
examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
pom.xml ebc2f2f
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 5c93a53
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 45e883d
server/base/src/main/java/org/apache/accumulo/server/trace/TraceFSDataInputStream.java 5162e01
server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java d3fbad7
server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 6c7fd47
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java f943ac1
server/master/src/main/java/org/apache/accumulo/master/Master.java e3fc69d
server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 49bb56d
server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 4858b8a
server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java f7bda49
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 54c75f8
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java ef3a0c9
shell/src/main/java/org/apache/accumulo/shell/Shell.java a0ff17a
shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
test/src/main/java/org/apache/accumulo/test/TestIngest.java 7f6c514
test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 4d9d479
test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 80ee990
test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java 03677f4
trace/pom.xml aacfb56
trace/src/main/java/org/apache/accumulo/trace/instrument/CloudtraceSpan.java PRE-CREATION
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceProxy.java cb93210
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
trace/src/main/java/org/apache/accumulo/trace/instrument/Tracer.java d70aeea
trace/src/main/java/org/apache/accumulo/trace/instrument/impl/MilliSpan.java b641a2c
trace/src/main/java/org/apache/accumulo/trace/instrument/impl/NullSpan.java 916b6cf
trace/src/main/java/org/apache/accumulo/trace/instrument/impl/RootMilliSpan.java c25e644
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/LogSpans.java dfed660
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/ZooSpanClient.java 84e3204
trace/src/main/java/org/apache/accumulo/trace/thrift/Annotation.java PRE-CREATION
trace/src/main/java/org/apache/accumulo/trace/thrift/RemoteSpan.java 416ae17
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
Diff: https://reviews.apache.org/r/27106/diff/
Testing
-------
File Attachments (updated)
----------------
ACCUMULO-898-5-additional-refactoring.patch
https://reviews.apache.org/media/uploaded/files/2014/11/06/ba7f147e-3918-4376-92ec-6feeb82ef31a__ACCUMULO-898-5-additional-refactoring.patch
Thanks,
Billie Rinaldi
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Josh Elser <jo...@gmail.com>.
> On Oct. 25, 2014, 6:18 a.m., Josh Elser wrote:
> > test/src/test/java/org/apache/accumulo/test/VolumeIT.java, line 518
> > <https://reviews.apache.org/r/27106/diff/1/?file=730996#file730996line518>
> >
> > Use ZooReader instead of ZooKeeper. You'll inherit the implicit retry logic we have.
Oops, just noticed that was an IT and not server code. Not a big deal then.
- Josh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review58494
-----------------------------------------------------------
On Oct. 23, 2014, 8:16 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:16 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> core/src/main/scripts/generate-thrift.sh 9fe743d
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/pom.xml 37adc00
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/pom.xml 60762be
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/pom.xml 8194121
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
> server/master/pom.xml 3b9684c
> server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/pom.xml a847183
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/pom.xml e1f61e6
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
> server/tserver/pom.xml 65c33ec
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
> shell/pom.xml a5af4b8
> shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/pom.xml 78909e1
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
> test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
> trace/pom.xml aacfb56
> trace/src/main/findbugs/exclude-filter.xml 408a32c
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/scripts/generate-thrift.sh b8a46b6
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> deleted files
> https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
> package / import changes
> https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
> thrift generated code
> https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
> On Oct. 25, 2014, 6:18 a.m., Josh Elser wrote:
> > core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java, line 95
> > <https://reviews.apache.org/r/27106/diff/1/?file=730957#file730957line95>
> >
> > Two concerns: the array from the ByteBuffer would only be valid between the arrayOffset() and the limit(). Having an array() from a ByteBuffer is optional. Can we assume that the span's data will always have an array we can use?
I think we can assume the latter. I'll fix the offset and limit.
> On Oct. 25, 2014, 6:18 a.m., Josh Elser wrote:
> > core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java, line 83
> > <https://reviews.apache.org/r/27106/diff/1/?file=730957#file730957line83>
> >
> > Re-use the ThreadLocal<SimpleDateFormatter>?
I'd rather fix this in another ticket, since this was just copied from the existing formatter.
> On Oct. 25, 2014, 6:18 a.m., Josh Elser wrote:
> > test/src/test/java/org/apache/accumulo/test/VolumeIT.java, line 518
> > <https://reviews.apache.org/r/27106/diff/1/?file=730996#file730996line518>
> >
> > Use ZooReader instead of ZooKeeper. You'll inherit the implicit retry logic we have.
>
> Josh Elser wrote:
> Oops, just noticed that was an IT and not server code. Not a big deal then.
I'll just drop these changes to VolumeIT, since they're not essential to the patch. (Jim said they improved this test's pass rate for him.)
- Billie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review58494
-----------------------------------------------------------
On Oct. 23, 2014, 8:16 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:16 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> core/src/main/scripts/generate-thrift.sh 9fe743d
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/pom.xml 37adc00
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/pom.xml 60762be
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/pom.xml 8194121
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
> server/master/pom.xml 3b9684c
> server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/pom.xml a847183
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/pom.xml e1f61e6
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
> server/tserver/pom.xml 65c33ec
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
> shell/pom.xml a5af4b8
> shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/pom.xml 78909e1
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
> test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
> trace/pom.xml aacfb56
> trace/src/main/findbugs/exclude-filter.xml 408a32c
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/scripts/generate-thrift.sh b8a46b6
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> deleted files
> https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
> package / import changes
> https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
> thrift generated code
> https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Josh Elser <jo...@gmail.com>.
> On Oct. 25, 2014, 6:18 a.m., Josh Elser wrote:
> > core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java, line 83
> > <https://reviews.apache.org/r/27106/diff/1/?file=730957#file730957line83>
> >
> > Re-use the ThreadLocal<SimpleDateFormatter>?
>
> Billie Rinaldi wrote:
> I'd rather fix this in another ticket, since this was just copied from the existing formatter.
Fine by me!
> On Oct. 25, 2014, 6:18 a.m., Josh Elser wrote:
> > test/src/test/java/org/apache/accumulo/test/VolumeIT.java, line 518
> > <https://reviews.apache.org/r/27106/diff/1/?file=730996#file730996line518>
> >
> > Use ZooReader instead of ZooKeeper. You'll inherit the implicit retry logic we have.
>
> Josh Elser wrote:
> Oops, just noticed that was an IT and not server code. Not a big deal then.
>
> Billie Rinaldi wrote:
> I'll just drop these changes to VolumeIT, since they're not essential to the patch. (Jim said they improved this test's pass rate for him.)
Ok. Not a big deal either way.
- Josh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review58494
-----------------------------------------------------------
On Nov. 6, 2014, 11:20 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 11:20 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-5.patch. This patch could stand alone. The file attached does a lot of additional refactoring, removing or deprecating everything in the trace module. So we can decide whether to apply just the first patch or both.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java a558760
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/AsyncSpanReceiver.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/SendSpansViaThrift.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 9586eaa
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 5c93a53
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 45e883d
> server/base/src/main/java/org/apache/accumulo/server/trace/TraceFSDataInputStream.java 5162e01
> server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java d3fbad7
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 6c7fd47
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java f943ac1
> server/master/src/main/java/org/apache/accumulo/master/Master.java e3fc69d
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 49bb56d
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 4858b8a
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java f7bda49
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 54c75f8
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java ef3a0c9
> shell/src/main/java/org/apache/accumulo/shell/Shell.java a0ff17a
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 7f6c514
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 4d9d479
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 80ee990
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java 03677f4
> trace/pom.xml aacfb56
> trace/src/main/java/org/apache/accumulo/trace/instrument/CloudtraceSpan.java PRE-CREATION
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceProxy.java cb93210
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/Tracer.java d70aeea
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/MilliSpan.java b641a2c
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/NullSpan.java 916b6cf
> trace/src/main/java/org/apache/accumulo/trace/instrument/impl/RootMilliSpan.java c25e644
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/LogSpans.java dfed660
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/ZooSpanClient.java 84e3204
> trace/src/main/java/org/apache/accumulo/trace/thrift/Annotation.java PRE-CREATION
> trace/src/main/java/org/apache/accumulo/trace/thrift/RemoteSpan.java 416ae17
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ACCUMULO-898-5-additional-refactoring.patch
> https://reviews.apache.org/media/uploaded/files/2014/11/06/ba7f147e-3918-4376-92ec-6feeb82ef31a__ACCUMULO-898-5-additional-refactoring.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/#review58494
-----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java
<https://reviews.apache.org/r/27106/#comment99541>
Re-use the ThreadLocal<SimpleDateFormatter>?
core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java
<https://reviews.apache.org/r/27106/#comment99539>
Two concerns: the array from the ByteBuffer would only be valid between the arrayOffset() and the limit(). Having an array() from a ByteBuffer is optional. Can we assume that the span's data will always have an array we can use?
server/master/src/main/java/org/apache/accumulo/master/Master.java
<https://reviews.apache.org/r/27106/#comment99542>
Sorry, I just pushed some changes this evening that will conflict here. :(
test/src/test/java/org/apache/accumulo/test/VolumeIT.java
<https://reviews.apache.org/r/27106/#comment99547>
Use ZooReader instead of ZooKeeper. You'll inherit the implicit retry logic we have.
- Josh Elser
On Oct. 23, 2014, 8:16 p.m., Billie Rinaldi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27106/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:16 p.m.)
>
>
> Review request for accumulo and Eric Newton.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
>
>
> Diffs
> -----
>
> assemble/bin/stop-all.sh 4bf06c0
> assemble/pom.xml 89a3747
> assemble/src/main/assemblies/component.xml 599d26c
> core/pom.xml 10e7d71
> core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
> core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
> core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
> core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
> core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
> core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
> core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
> core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
> core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
> core/src/main/scripts/generate-thrift.sh 9fe743d
> docs/src/main/asciidoc/chapters/administration.txt d5e73f0
> docs/src/main/resources/distributedTracing.html 54c9095
> examples/simple/pom.xml 37adc00
> examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
> minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
> pom.xml ebc2f2f
> server/base/pom.xml 60762be
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
> server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
> server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
> server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
> server/gc/pom.xml 8194121
> server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
> server/master/pom.xml 3b9684c
> server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
> server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
> server/monitor/pom.xml a847183
> server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
> server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
> server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
> server/tracer/pom.xml e1f61e6
> server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
> server/tserver/pom.xml 65c33ec
> server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
> server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
> server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
> server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
> server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
> shell/pom.xml a5af4b8
> shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
> shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
> test/pom.xml 78909e1
> test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
> test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
> test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
> test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
> test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
> test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
> test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
> trace/pom.xml aacfb56
> trace/src/main/findbugs/exclude-filter.xml 408a32c
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
> trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
> trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
> trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
> trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
> trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
> trace/src/main/scripts/generate-thrift.sh b8a46b6
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/main/thrift/trace.thrift 76bcafe
> trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
>
> Diff: https://reviews.apache.org/r/27106/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> deleted files
> https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
> package / import changes
> https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
> thrift generated code
> https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
>
>
> Thanks,
>
> Billie Rinaldi
>
>
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 8:16 p.m.)
Review request for accumulo and Eric Newton.
Repository: accumulo
Description
-------
Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
Diffs
-----
assemble/bin/stop-all.sh 4bf06c0
assemble/pom.xml 89a3747
assemble/src/main/assemblies/component.xml 599d26c
core/pom.xml 10e7d71
core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
core/src/main/scripts/generate-thrift.sh 9fe743d
docs/src/main/asciidoc/chapters/administration.txt d5e73f0
docs/src/main/resources/distributedTracing.html 54c9095
examples/simple/pom.xml 37adc00
examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
pom.xml ebc2f2f
server/base/pom.xml 60762be
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
server/gc/pom.xml 8194121
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
server/master/pom.xml 3b9684c
server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
server/monitor/pom.xml a847183
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
server/tracer/pom.xml e1f61e6
server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
server/tserver/pom.xml 65c33ec
server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
shell/pom.xml a5af4b8
shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
test/pom.xml 78909e1
test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
trace/pom.xml aacfb56
trace/src/main/findbugs/exclude-filter.xml 408a32c
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
trace/src/main/scripts/generate-thrift.sh b8a46b6
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
Diff: https://reviews.apache.org/r/27106/diff/
Testing
-------
File Attachments
----------------
deleted files
https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
package / import changes
https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
thrift generated code
https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
Thanks,
Billie Rinaldi
Re: Review Request 27106: ACCUMULO-898 convert to htrace
Posted by Billie Rinaldi <bi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27106/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 8:15 p.m.)
Review request for accumulo and Eric Newton.
Repository: accumulo
Description
-------
Main diff is ACCUMULO-898-4-base.patch. Additional files attached have the rest of the diffs that make up ACCUMULO-898-4.patch.
Diffs
-----
assemble/bin/stop-all.sh 4bf06c0
assemble/pom.xml 89a3747
assemble/src/main/assemblies/component.xml 599d26c
core/pom.xml 10e7d71
core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java 39b460d
core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92
core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java fc20535
core/src/main/java/org/apache/accumulo/core/trace/DistributedTrace.java 83f5c26
core/src/main/java/org/apache/accumulo/core/trace/Span.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/Trace.java PRE-CREATION
core/src/main/java/org/apache/accumulo/core/trace/TraceDump.java b44cc3e
core/src/main/java/org/apache/accumulo/core/trace/TraceFormatter.java 9d860d9
core/src/main/java/org/apache/accumulo/core/trace/ZooTraceClient.java 4c8b837
core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java da4e567
core/src/main/scripts/generate-thrift.sh 9fe743d
docs/src/main/asciidoc/chapters/administration.txt d5e73f0
docs/src/main/resources/distributedTracing.html 54c9095
examples/simple/pom.xml 37adc00
examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/TracingExample.java a542263
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloInstance.java 54897cb
pom.xml ebc2f2f
server/base/pom.xml 60762be
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java ac7ad60
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214
server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java 7e1cc97
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java 1f59531
server/gc/pom.xml 8194121
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java 84ad28b
server/master/pom.xml 3b9684c
server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4
server/master/src/main/java/org/apache/accumulo/master/replication/ReplicationDriver.java a52f743
server/monitor/pom.xml a847183
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java 7a724f8
server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/ShowTrace.java a476201
server/monitor/src/test/java/org/apache/accumulo/monitor/ShowTraceLinkTypeTest.java a630434
server/tracer/pom.xml e1f61e6
server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java 189bb39
server/tserver/pom.xml 65c33ec
server/tserver/src/main/java/org/apache/accumulo/tserver/BulkFailedCopyProcessor.java ff0097a
server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java 9a1117d
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 51e3d1a
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 732907d
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java caff246
shell/pom.xml a5af4b8
shell/src/main/java/org/apache/accumulo/shell/Shell.java 2ebdb6c
shell/src/main/java/org/apache/accumulo/shell/commands/TraceCommand.java 7f63570
test/pom.xml 78909e1
test/src/main/java/org/apache/accumulo/test/TestIngest.java 0548f4c
test/src/main/java/org/apache/accumulo/test/VerifyIngest.java 74b03e4
test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 570a53c
test/src/test/java/org/apache/accumulo/test/VolumeIT.java 5e54957
test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java 4f5fc7d
test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 210e057
test/src/test/java/org/apache/accumulo/test/functional/SimpleMacIT.java f70a7a8
trace/pom.xml aacfb56
trace/src/main/findbugs/exclude-filter.xml 408a32c
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/CountSampler.java 9a5bdbb
trace/src/main/java/org/apache/accumulo/trace/instrument/Sampler.java 4abb40a
trace/src/main/java/org/apache/accumulo/trace/instrument/Span.java 5267174
trace/src/main/java/org/apache/accumulo/trace/instrument/Trace.java 19171c4
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceCallable.java c3072b1
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceExecutorService.java 04dcc39
trace/src/main/java/org/apache/accumulo/trace/instrument/TraceRunnable.java 41c765d
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/AsyncSpanReceiver.java 4eebd69
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SendSpansViaThrift.java 4967d97
trace/src/main/java/org/apache/accumulo/trace/instrument/receivers/SpanReceiver.java b44e51e
trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
trace/src/main/java/org/apache/accumulo/trace/thrift/TInfo.java 9f899bf
trace/src/main/scripts/generate-thrift.sh b8a46b6
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/main/thrift/trace.thrift 76bcafe
trace/src/test/java/org/apache/accumulo/trace/instrument/TracerTest.java f338bd8
Diff: https://reviews.apache.org/r/27106/diff/
Testing
-------
File Attachments
----------------
deleted files
https://reviews.apache.org/media/uploaded/files/2014/10/23/09e7c4bb-1db6-411e-b258-4579fd170e65__ACCUMULO-898-3-deleted.patch
package / import changes
https://reviews.apache.org/media/uploaded/files/2014/10/23/9b0d4442-aa19-4cff-9dc1-0a1b3d7cef2d__ACCUMULO-898-3-package-import-only.patch
thrift generated code
https://reviews.apache.org/media/uploaded/files/2014/10/23/21364197-afa2-4ce6-88e0-9664d58862e2__ACCUMULO-898-3-generated.patch
Thanks,
Billie Rinaldi