[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5904: Add change log count to user response payload and username as query param in logs API

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #5904:
URL: https://github.com/apache/trafficcontrol/pull/5904#discussion_r652177150



##########
File path: traffic_portal/app/src/common/modules/form/user/FormUserController.js
##########
@@ -37,6 +37,16 @@ var FormUserController = function(user, $scope, $location, formUtils, stringUtil
             });
     };
 
+    $scope.changeLogs = [];
+
+    $scope.getChangeLogs = function(userName) {
+        changeLogService.getChangeLogs({ username: userName })

Review comment:
       I believe this call to `getChangeLogs` is un-needed. The first thing the [change-logs page does](https://github.com/apache/trafficcontrol/blob/5b6db34a8a2c930aa56ec73249161f26cd876328/traffic_portal/app/src/modules/private/changeLogs/list/index.js#L35) is run a `getChangeLogs`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org