You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/21 08:41:07 UTC

[GitHub] [camel-k] squakez commented on a diff in pull request #3828: chore(test) : TestRunAndLog to pass on mac os

squakez commented on code in PR #3828:
URL: https://github.com/apache/camel-k/pull/3828#discussion_r1027716411


##########
pkg/util/command_test.go:
##########
@@ -56,5 +57,9 @@ func TestRunAndLogInvalid(t *testing.T) {
 	err := RunAndLog(context.Background(), cmd, loggerInfo, loggerError)
 
 	assert.NotNil(t, err)
-	assert.ErrorContains(t, err, "exit status 1")
+	if runtime.GOOS == "darwin" {
+	        assert.ErrorContains(t, err, "exit status 1")

Review Comment:
   I'd prefer to have a switch here to test linux ("date: invalid date ‘sa’"), darwin (we should understand which is the output there) and else any other platform (ie, windows, with generic "exit status 1").



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org